[mlir][SCF] Report error when lowering to cf in single block op #65305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report an error when lowering an "scf" op inside of a parent that supports only a single block (e.g., "scf.forall", which does currently not have a "cf" lowering). This indicates a problem in the pass pipeline: scf-to-cf is typically one of the last passes to run and ops that do not support unstructured control flow should have been lowered already. Before this change, the lowering produced IR that does not verify.
ftynse
reviewed
Sep 5, 2023
Dialect conversion traverses the IR pre-order. But generally speaking, another approach would be to add an |
joker-eph
reviewed
Sep 5, 2023
| @@ -370,6 +373,9 @@ LogicalResult ForLowering::matchAndRewrite(ForOp forOp, | |||
| LogicalResult IfLowering::matchAndRewrite(IfOp ifOp, | |||
| PatternRewriter &rewriter) const { | |||
| auto loc = ifOp.getLoc(); | |||
| if (ifOp->getParentOp()->hasTrait<OpTrait::SingleBlock>()) | |||
| return ifOp->emitError( | |||
| "cannot lower op inside parent that expects a single block"); | |||
There was a problem hiding this comment.
Please use notifyMatchFailure instead
|
I'm not happy with solution yet, but don't have time to work at this at the moment. The issue with "scf.forall" has been fixed with #65449. Closing this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report an error when lowering an "scf" op inside of a parent that supports only a single block (e.g., "scf.forall", which does currently not have a "cf" lowering). This indicates a problem in the pass pipeline: scf-to-cf is typically one of the last passes to run and ops that do not support unstructured control flow should have been lowered already.
Before this change, the lowering produced IR that does not verify.