Skip to content

[test] Use host platform specific error message substitution in lit tests #65328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2023
Merged

[test] Use host platform specific error message substitution in lit tests #65328

merged 1 commit into from
Sep 6, 2023

Conversation

abhina-sree
Copy link
Contributor

On z/OS, the following error message is not matched correctly in lit tests.

EDC5129I No such file or directory.
This patch uses a lit config substitution to check for platform specific error messages.

@abhina-sree abhina-sree changed the title Use host platform specific error message substitution in lit tests [test] Use host platform specific error message substitution in lit tests Sep 5, 2023
@abhina-sree abhina-sree self-assigned this Sep 5, 2023
Copy link
Contributor

@fanbo-meng fanbo-meng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhina-sree abhina-sree merged commit 05eaff1 into llvm:main Sep 6, 2023
Guzhu-AMD pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Sep 7, 2023
Local branch amd-gfx 314f2ed Merged main:74f985b793bf into amd-gfx:f5c1367337e7
Remote branch main 05eaff1 [test] Use host platform specific error message substitution in lit tests (llvm#65328)
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
…ests (llvm#65328)

On z/OS, the following error message is not matched correctly in lit
tests.

`EDC5129I No such file or directory.`
This patch uses a lit config substitution to check for platform specific
error messages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants