Skip to content

[clang-format][NFC] Fix broken dump_format_help.py and sync RST file #65429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

owenca
Copy link
Contributor

@owenca owenca commented Sep 6, 2023

Running dump_format_help.py in clang/docs/tools:

warning: line too long:
                                      relative to the current working directory when reading stdin.
warning: line too long:
     --files=<filename>             - A file containing a list of files to process, one per line.
warning: line too long:
     --help-list                    - Display list of available options (--help-list-hidden for more)
Traceback (most recent call last):
  File "/Users/Owen/remove-braces/clang/docs/tools/./dump_format_help.py", line 63, in <module>
    contents = substitute(contents, "FORMAT_HELP", help_text)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/Owen/remove-braces/clang/docs/tools/./dump_format_help.py", line 17, in substitute
    return re.sub(pattern, "%s", text, flags=re.S) % replacement
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
TypeError: not enough arguments for format string

@owenca owenca requested review from a team as code owners September 6, 2023 01:13
@owenca owenca requested review from mkurdej and removed request for a team September 6, 2023 05:12
@owenca owenca changed the title [clang-format] Fix broken dump_format_help.py and sync the RST file [clang-format][NFC] Fix broken dump_format_help.py and sync the RST file Sep 7, 2023
@owenca owenca changed the title [clang-format][NFC] Fix broken dump_format_help.py and sync the RST file [clang-format][NFC] Fix broken dump_format_help.py and sync RST file Sep 7, 2023
@owenca owenca merged commit c47c480 into llvm:main Sep 7, 2023
@owenca owenca deleted the dump_format_help branch September 7, 2023 07:43
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
…lvm#65429)

Running `dump_format_help.py` in `clang/docs/tools`:
```
warning: line too long:
                                      relative to the current working directory when reading stdin.
warning: line too long:
     --files=<filename>             - A file containing a list of files to process, one per line.
warning: line too long:
     --help-list                    - Display list of available options (--help-list-hidden for more)
Traceback (most recent call last):
  File "/Users/Owen/remove-braces/clang/docs/tools/./dump_format_help.py", line 63, in <module>
    contents = substitute(contents, "FORMAT_HELP", help_text)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/Owen/remove-braces/clang/docs/tools/./dump_format_help.py", line 17, in substitute
    return re.sub(pattern, "%s", text, flags=re.S) % replacement
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
TypeError: not enough arguments for format string
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants