llvm · joker-eph · Sep 8, 2023 · Sep 9, 2023
diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst
@@ -46,21 +46,33 @@ quality.
 Stay Informed
 -------------
 
-Developers should stay informed by reading the `LLVM Discourse forums`_.
-If you are doing anything more than just casual work on LLVM, it is suggested that you also
-subscribe to the "commits" mailing list for the subproject you're interested in,
+Developers should stay informed by reading the `LLVM Discourse forums`_ and subscribing
+to the categories of interest for notifications.
+
+Paying attention to changes being made by others is a good way to see what other people
+are interested in and watching the flow of the project as a whole.
+
+Contibutions to the project are made through :ref:`GitHub Pull Requests <github-reviews>`.
+You can subscribe to notification for areas of the codebase by joining
+one of the `pr-subscribers-* <https://github.com/orgs/llvm/teams?query=issue-subscribers>`_
+GitHub teams. This `mapping <https://github.com/llvm/llvm-project/blob/main/.github/new-prs-labeler.yml>`_
+indicates which team is associated with a particular paths in the repository.
+
+You can also subscribe to the "commits" mailing list for a subproject you're interested in,
 such as `llvm-commits
 <http://lists.llvm.org/mailman/listinfo/llvm-commits>`_, `cfe-commits
 <http://lists.llvm.org/mailman/listinfo/cfe-commits>`_, or `lldb-commits
-<http://lists.llvm.org/mailman/listinfo/lldb-commits>`_.  Reading the
-"commits" list and paying attention to changes being made by others is a good
-way to see what other people are interested in and watching the flow of the
-project as a whole.
-
-We recommend that active developers monitor incoming issues to our `GitHub issue tracker <https://github.com/llvm/llvm-project/issues>`_ and preferably subscribe to the `llvm-bugs
+<http://lists.llvm.org/mailman/listinfo/lldb-commits>`_.
+
+Missing features and bugs are tracked through our `GitHub issue tracker <https://github.com/llvm/llvm-project/issues>`_
+and assigned labels. We recommend that active developers monitor incoming issues.
+You can subscribe for notification for specific components by joining
+one of the `issue-subscribers-* <https://github.com/orgs/llvm/teams?query=issue-subscribers>`_
+teams.
+You may also subscribe to the `llvm-bugs
 <http://lists.llvm.org/mailman/listinfo/llvm-bugs>`_ email list to keep track
-of bugs and enhancements occurring in LLVM.  We really appreciate people who are
-proactive at catching incoming bugs in their components and dealing with them
+of bugs and enhancements occurring in the entire project.  We really appreciate people
+who are proactive at catching incoming bugs in their components and dealing with them
 promptly.
 
 Please be aware that all public LLVM mailing lists and discourse forums are public and archived, and

diff --git a/llvm/lib/FileCheck/CMakeLists.txt b/llvm/lib/FileCheck/CMakeLists.txt
@@ -1,8 +1,6 @@
-add_llvm_component_library(LLVMFileCheck
-  FileCheck.cpp
+add_llvm_component_library(LLVMFileCheck FileCheck.cpp
 
-  ADDITIONAL_HEADER_DIRS
-  "${LLVM_MAIN_INCLUDE_DIR}/llvm/FileCheck"
-)
+                               ADDITIONAL_HEADER_DIRS
+                           "${LLVM_MAIN_INCLUDE_DIR}/llvm/FileCheck")
 
-target_link_libraries(LLVMFileCheck LLVMSupport)
+    target_link_libraries(LLVMFileCheck LLVMSupport)
diff --git a/llvm/lib/FileCheck/FileCheck.cpp b/llvm/lib/FileCheck/FileCheck.cpp
@@ -9,8 +9,8 @@
 // FileCheck does a line-by line check of a file that validates whether it
 // contains the expected content.  This is useful for regression tests etc.
 //
-// This file implements most of the API that will be used by the FileCheck utility
-// as well as various unittests.
+// This file implements most of the API that will be used by the FileCheck
+// utility as well as various unittests.
 //===----------------------------------------------------------------------===//
 
 #include "llvm/FileCheck/FileCheck.h"
@@ -307,7 +307,7 @@ Pattern::parseVariable(StringRef &Str, const SourceMgr &SM) {
 
   StringRef Name = Str.take_front(I);
   Str = Str.substr(I);
-  return VariableProperties {Name, IsPseudo};
+  return VariableProperties{Name, IsPseudo};
 }
 
 // StringRef holding all characters considered as horizontal whitespaces by
@@ -1847,20 +1847,22 @@ bool FileCheck::readCheckFile(
 
     // Verify that CHECK-LABEL lines do not define or use variables
     if ((CheckTy == Check::CheckLabel) && P.hasVariable()) {
-      SM.PrintMessage(
-          SMLoc::getFromPointer(UsedPrefixStart), SourceMgr::DK_Error,
-          "found '" + UsedPrefix + "-LABEL:'"
-                                   " with variable definition or use");
+      SM.PrintMessage(SMLoc::getFromPointer(UsedPrefixStart),
+                      SourceMgr::DK_Error,
+                      "found '" + UsedPrefix +
+                          "-LABEL:'"
+                          " with variable definition or use");
       return true;
     }
 
-    // Verify that CHECK-NEXT/SAME/EMPTY lines have at least one CHECK line before them.
+    // Verify that CHECK-NEXT/SAME/EMPTY lines have at least one CHECK line
+    // before them.
     if ((CheckTy == Check::CheckNext || CheckTy == Check::CheckSame ||
          CheckTy == Check::CheckEmpty) &&
         CheckStrings->empty()) {
-      StringRef Type = CheckTy == Check::CheckNext
-                           ? "NEXT"
-                           : CheckTy == Check::CheckEmpty ? "EMPTY" : "SAME";
+      StringRef Type = CheckTy == Check::CheckNext    ? "NEXT"
+                       : CheckTy == Check::CheckEmpty ? "EMPTY"
+                                                      : "SAME";
       SM.PrintMessage(SMLoc::getFromPointer(UsedPrefixStart),
                       SourceMgr::DK_Error,
                       "found '" + UsedPrefix + "-" + Type +

diff --git a/llvm/lib/Frontend/CMakeLists.txt b/llvm/lib/Frontend/CMakeLists.txt
@@ -1,3 +1 @@
-add_subdirectory(HLSL)
-add_subdirectory(OpenACC)
-add_subdirectory(OpenMP)
+add_subdirectory(HLSL) add_subdirectory(OpenACC) add_subdirectory(OpenMP)
diff --git a/llvm/lib/Frontend/HLSL/CMakeLists.txt b/llvm/lib/Frontend/HLSL/CMakeLists.txt
@@ -1,14 +1,10 @@
-add_llvm_component_library(LLVMFrontendHLSL
-  HLSLResource.cpp
+add_llvm_component_library(LLVMFrontendHLSL HLSLResource.cpp
 
-  ADDITIONAL_HEADER_DIRS
-  ${LLVM_MAIN_INCLUDE_DIR}/llvm/Frontend
-  ${LLVM_MAIN_INCLUDE_DIR}/llvm/Frontend/HLSL
+                               ADDITIONAL_HEADER_DIRS ${LLVM_MAIN_INCLUDE_DIR} /
+                           llvm / Frontend ${LLVM_MAIN_INCLUDE_DIR} / llvm /
+                           Frontend /
+                           HLSL
 
-  DEPENDS
-  intrinsics_gen
+                               DEPENDS intrinsics_gen
 
-  LINK_COMPONENTS
-  Core
-  Support
-  )
+                                   LINK_COMPONENTS Core Support)
diff --git a/llvm/lib/Frontend/OpenACC/CMakeLists.txt b/llvm/lib/Frontend/OpenACC/CMakeLists.txt
@@ -1,13 +1,10 @@
-add_llvm_component_library(LLVMFrontendOpenACC
-  ACC.cpp
+add_llvm_component_library(LLVMFrontendOpenACC ACC.cpp
 
-  ADDITIONAL_HEADER_DIRS
-  ${LLVM_MAIN_INCLUDE_DIR}/llvm/Frontend
-  ${LLVM_MAIN_INCLUDE_DIR}/llvm/Frontend/OpenACC
+                               ADDITIONAL_HEADER_DIRS ${LLVM_MAIN_INCLUDE_DIR} /
+                           llvm / Frontend ${LLVM_MAIN_INCLUDE_DIR} / llvm /
+                           Frontend /
+                           OpenACC
 
-  DEPENDS
-  acc_gen
-)
-
-target_link_libraries(LLVMFrontendOpenACC LLVMSupport)
+                               DEPENDS acc_gen)
 
+    target_link_libraries(LLVMFrontendOpenACC LLVMSupport)
diff --git a/llvm/lib/Frontend/OpenMP/CMakeLists.txt b/llvm/lib/Frontend/OpenMP/CMakeLists.txt
@@ -1,23 +1,11 @@
-add_llvm_component_library(LLVMFrontendOpenMP
-  OMP.cpp
-  OMPContext.cpp
-  OMPIRBuilder.cpp
+add_llvm_component_library(
+    LLVMFrontendOpenMP OMP.cpp OMPContext.cpp OMPIRBuilder.cpp
 
-  ADDITIONAL_HEADER_DIRS
-  ${LLVM_MAIN_INCLUDE_DIR}/llvm/Frontend
-  ${LLVM_MAIN_INCLUDE_DIR}/llvm/Frontend/OpenMP
+        ADDITIONAL_HEADER_DIRS ${LLVM_MAIN_INCLUDE_DIR} /
+    llvm / Frontend ${LLVM_MAIN_INCLUDE_DIR} / llvm / Frontend /
+    OpenMP
 
-  DEPENDS
-  intrinsics_gen
-  omp_gen
+        DEPENDS intrinsics_gen omp_gen
 
-  LINK_COMPONENTS
-  Core
-  Support
-  TargetParser
-  TransformUtils
-  Analysis
-  MC
-  Scalar
-  BitReader
-  )
+            LINK_COMPONENTS Core Support TargetParser TransformUtils Analysis MC
+                Scalar BitReader)
diff --git a/llvm/lib/FuzzMutate/CMakeLists.txt b/llvm/lib/FuzzMutate/CMakeLists.txt
@@ -1,37 +1,23 @@
-# Generic helper for fuzzer binaries.
-# This should not depend on LLVM IR etc.
-add_llvm_component_library(LLVMFuzzerCLI
-  FuzzerCLI.cpp
-  PARTIAL_SOURCES_INTENDED
+#Generic helper for fuzzer binaries.
+#This should not depend on LLVM IR etc.
+add_llvm_component_library(LLVMFuzzerCLI FuzzerCLI.cpp PARTIAL_SOURCES_INTENDED
 
-  ADDITIONAL_HEADER_DIRS
-  ${LLVM_MAIN_INCLUDE_DIR}/llvm/FuzzMutate
+                               ADDITIONAL_HEADER_DIRS ${LLVM_MAIN_INCLUDE_DIR} /
+                           llvm /
+                           FuzzMutate
 
-  LINK_COMPONENTS
-  Support
-  TargetParser
-  )
+                               LINK_COMPONENTS Support TargetParser)
 
-# Library for using LLVM IR together with fuzzers.
-add_llvm_component_library(LLVMFuzzMutate
-  IRMutator.cpp
-  OpDescriptor.cpp
-  Operations.cpp
-  RandomIRBuilder.cpp
+#Library for using LLVM IR together with fuzzers.
+    add_llvm_component_library(
+        LLVMFuzzMutate IRMutator.cpp OpDescriptor.cpp Operations
+            .cpp RandomIRBuilder.cpp
 
-  ADDITIONAL_HEADER_DIRS
-  ${LLVM_MAIN_INCLUDE_DIR}/llvm/FuzzMutate
+                ADDITIONAL_HEADER_DIRS ${LLVM_MAIN_INCLUDE_DIR} /
+        llvm /
+        FuzzMutate
 
-  DEPENDS
-  intrinsics_gen
+            DEPENDS intrinsics_gen
 
-  LINK_COMPONENTS
-  Analysis
-  BitReader
-  BitWriter
-  Core
-  Scalar
-  Support
-  TargetParser
-  TransformUtils
-  )
+                LINK_COMPONENTS Analysis BitReader BitWriter Core Scalar Support
+                    TargetParser TransformUtils)
diff --git a/llvm/lib/Fuzzer/README.txt b/llvm/lib/Fuzzer/README.txt
@@ -1 +1 @@
-libFuzzer was moved to compiler-rt in  https://reviews.llvm.org/D36908.
+libFuzzer was moved to compiler - rt in https: // reviews.llvm.org/D36908.
diff --git a/llvm/lib/InterfaceStub/CMakeLists.txt b/llvm/lib/InterfaceStub/CMakeLists.txt
@@ -1,12 +1,4 @@
-add_llvm_component_library(LLVMInterfaceStub
-  ELFObjHandler.cpp
-  IFSHandler.cpp
-  IFSStub.cpp
+add_llvm_component_library(
+    LLVMInterfaceStub ELFObjHandler.cpp IFSHandler.cpp IFSStub.cpp
 
-  LINK_COMPONENTS
-  BinaryFormat
-  MC
-  Object
-  Support
-  TargetParser
-)
+        LINK_COMPONENTS BinaryFormat MC Object Support TargetParser)
diff --git a/llvm/lib/MCA/HardwareUnits/LSUnit.cpp b/llvm/lib/MCA/HardwareUnits/LSUnit.cpp
@@ -96,8 +96,8 @@ unsigned LSUnit::dispatch(const InstRef &IR) {
     if (CurrentStoreBarrierGroupID) {
       MemoryGroup &StoreGroup = getGroup(CurrentStoreBarrierGroupID);
       LLVM_DEBUG(dbgs() << "[LSUnit]: GROUP DEP: ("
-                        << CurrentStoreBarrierGroupID
-                        << ") --> (" << NewGID << ")\n");
+                        << CurrentStoreBarrierGroupID << ") --> (" << NewGID
+                        << ")\n");
       StoreGroup.addSuccessor(&NewGroup, true);
     }
 
@@ -110,7 +110,6 @@ unsigned LSUnit::dispatch(const InstRef &IR) {
       StoreGroup.addSuccessor(&NewGroup, !assumeNoAlias());
     }
 
-
     CurrentStoreGroupID = NewGID;
     if (IsStoreBarrier)
       CurrentStoreBarrierGroupID = NewGID;
@@ -165,8 +164,7 @@ unsigned LSUnit::dispatch(const InstRef &IR) {
     if (IsLoadBarrier) {
       if (ImmediateLoadDominator) {
         MemoryGroup &LoadGroup = getGroup(ImmediateLoadDominator);
-        LLVM_DEBUG(dbgs() << "[LSUnit]: GROUP DEP: ("
-                          << ImmediateLoadDominator
+        LLVM_DEBUG(dbgs() << "[LSUnit]: GROUP DEP: (" << ImmediateLoadDominator
                           << ") --> (" << NewGID << ")\n");
         LoadGroup.addSuccessor(&NewGroup, true);
       }
@@ -175,8 +173,8 @@ unsigned LSUnit::dispatch(const InstRef &IR) {
       if (CurrentLoadBarrierGroupID) {
         MemoryGroup &LoadGroup = getGroup(CurrentLoadBarrierGroupID);
         LLVM_DEBUG(dbgs() << "[LSUnit]: GROUP DEP: ("
-                          << CurrentLoadBarrierGroupID
-                          << ") --> (" << NewGID << ")\n");
+                          << CurrentLoadBarrierGroupID << ") --> (" << NewGID
+                          << ")\n");
         LoadGroup.addSuccessor(&NewGroup, true);
       }
     }

diff --git a/llvm/lib/MCA/HardwareUnits/RetireControlUnit.cpp b/llvm/lib/MCA/HardwareUnits/RetireControlUnit.cpp
@@ -66,7 +66,8 @@ const RetireControlUnit::RUToken &RetireControlUnit::getCurrentToken() const {
 
 unsigned RetireControlUnit::computeNextSlotIdx() const {
   const RetireControlUnit::RUToken &Current = getCurrentToken();
-  unsigned NextSlotIdx = CurrentInstructionSlotIdx + std::max(1U, Current.NumSlots);
+  unsigned NextSlotIdx =
+      CurrentInstructionSlotIdx + std::max(1U, Current.NumSlots);
   return NextSlotIdx % Queue.size();
 }
 
@@ -82,12 +83,13 @@ void RetireControlUnit::consumeCurrentToken() {
   CurrentInstructionSlotIdx += std::max(1U, Current.NumSlots);
   CurrentInstructionSlotIdx %= Queue.size();
   AvailableEntries += Current.NumSlots;
-  Current = { InstRef(), 0U, false };
+  Current = {InstRef(), 0U, false};
 }
 
 void RetireControlUnit::onInstructionExecuted(unsigned TokenID) {
   assert(Queue.size() > TokenID);
-  assert(Queue[TokenID].IR.getInstruction() && "Instruction was not dispatched!");
+  assert(Queue[TokenID].IR.getInstruction() &&
+         "Instruction was not dispatched!");
   assert(Queue[TokenID].Executed == false && "Instruction already executed!");
   Queue[TokenID].Executed = true;
 }

diff --git a/llvm/lib/MCA/Stages/InstructionTables.cpp b/llvm/lib/MCA/Stages/InstructionTables.cpp
@@ -24,8 +24,7 @@ Error InstructionTables::execute(InstRef &IR) {
   UsedResources.clear();
 
   // Identify the resources consumed by this instruction.
-  for (const std::pair<uint64_t, ResourceUsage> &Resource :
-       Desc.Resources) {
+  for (const std::pair<uint64_t, ResourceUsage> &Resource : Desc.Resources) {
     // Skip zero-cycle resources (i.e., unused resources).
     if (!Resource.second.size())
       continue;
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		libFuzzer was moved to compiler-rt in https://reviews.llvm.org/D36908.
		libFuzzer was moved to compiler - rt in https: // reviews.llvm.org/D36908.