[LTO][CodeGen] Test LTO pipeline choices more thoroughly #65485
Merged
+13
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was looking only for the bitcode writer pass; it should check the full pipeline to make sure the choice is as intended.
|
This came up because Sony makes slightly different choices downstream, and we didn't get it exactly right in all cases. |
avillega
pushed a commit
to avillega/llvm-project
that referenced
this pull request
Sep 11, 2023
The test was looking only for the bitcode writer pass; it should check the full pipeline to make sure the choice is as intended.
Guzhu-AMD
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Sep 14, 2023
Local branch amd-gfx b7ec5b5 Merged main:c16adb0dcb1f into amd-gfx:0d8d0068a932 Remote branch main a991ccd [LTO][CodeGen] Test LTO pipeline choices more thoroughly (llvm#65485)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was looking only for the bitcode writer pass; it should check the full pipeline to make sure the choice is as intended.