Skip to content

[ADT] Fix a comment typo #65497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2023
Merged

[ADT] Fix a comment typo #65497

merged 1 commit into from
Sep 6, 2023

Conversation

kazutakahirata
Copy link
Contributor

No description provided.

@tbaederr
Copy link
Contributor

tbaederr commented Sep 6, 2023

Why is this NFC change a PR at all?

@kazutakahirata
Copy link
Contributor Author

Why is this NFC change a PR at all?

Sorry, I am trying to learn the PR workflow. I'd appreciate an approval so I can experience the entire process. Thanks!

@MaskRay
Copy link
Member

MaskRay commented Sep 6, 2023

Learning as well...

% gh pr review 65497
? What kind of review do you want to give? Approve
? Review body <Received>
? Submit? Yes
✓ Approved pull request #65497

mtrofin
mtrofin approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@mtrofin mtrofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kazutakahirata kazutakahirata merged commit 06d2db2 into llvm:main Sep 6, 2023
@kazutakahirata kazutakahirata deleted the my_change branch September 6, 2023 18:11
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
@kazutakahirata
[ADT] Fix a comment typo (llvm#65497)
47d124c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaskRay MaskRay MaskRay approved these changes

@mtrofin mtrofin mtrofin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kazutakahirata @tbaederr @MaskRay @mtrofin