[libc++] Implement `views::join_with` #65536

JMazurkiewicz · 2023-09-06T21:40:41Z

Implement "P2441R2 views::join_with" (https://wg21.link/P2441R2), closes P2441R2: views::join_with #105185
Implement LWG4074 (https://wg21.link/LWG4074), closes LWG4074: compatible-joinable-ranges is underconstrained #105346
Complete implementation of "P2711R1 Making multi-param constructors of views explicit" (https://wg21.link/P2711R1), closes P2711R1: Making multi-param constructors of views explicit #105252
Complete implementation of "P2770R0 Stashing stashing iterators for proper flattening" (https://wg21.link/P2770R0), closes P2770R0: Stashing stashing iterators for proper flattening #105250

libcxx/docs/Status/Cxx23Papers.csv

ldionne · 2023-09-15T20:55:42Z

@JMazurkiewicz Please ping us when this is ready to review and make it a non-draft.

This patch adds a mention that the following papers are in progress: * P2770R0: #66033 * P2441R2 and P2711R1: #65536

github-actions · 2024-02-03T00:00:05Z

✅ With the latest revision this PR passed the C/C++ code formatter.

H-G-Hristov · 2024-05-10T14:27:22Z

I guess with constexpr variant this cool feature can be finalized now :)

…with

https://www.githubstatus.com/incidents/nm83zrdky73y

…with

JMazurkiewicz · 2025-04-14T15:25:19Z

Ping @huixie90

…with

huixie90

LGTM with some nits. Thanks very much for the patch!

libcxx/docs/ReleaseNotes/21.rst

libcxx/include/__ranges/join_with_view.h

ldionne · 2025-05-12T20:52:48Z

Sorry for the churn about the pending-ci tag -- I missed that there were still a few comments to resolve before merging.

…ase>` Comment: llvm#65536 (comment)

Comment: llvm#65536 (comment)

…of `__iterator` Comment: llvm#65536 (comment)

…s with MSVC

JMazurkiewicz · 2025-05-20T15:01:58Z

Thank you @huixie90 for your review. I've pushed commits addressing your latest comments (95ea7bc, 8ab29fb, 7198928), and changing three more things:

6cb18ac - This commit fixes problem with friendship (similar to this one) in the test suite.
37525db - This commit fixes truncation warnings when testing MSVC standard library (so it's easier for them to update their llvm submodule).
de46d63 - LWG-4074 removed compatible-joinable-ranges, this commit updates synopsis.

…with

frederick-vs-ja

LGTM. The CI failures are probably unrelated.

huixie90 · 2025-06-21T09:54:41Z

Merging this as comments are addressed. CI is green except for msan, which is an existing issue on main and unrelated to this patch

* Implement "P2441R2 `views::join_with`" (https://wg21.link/P2441R2), closes llvm#105185 * Implement LWG4074 (https://wg21.link/LWG4074), closes llvm#105346 * Complete implementation of "P2711R1 Making multi-param constructors of views explicit" (https://wg21.link/P2711R1), closes llvm#105252 * Complete implementation of "P2770R0 Stashing stashing iterators for proper flattening" (https://wg21.link/P2770R0), closes llvm#105250

github-actions bot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Sep 6, 2023

JMazurkiewicz force-pushed the libcxx/ranges/join_with branch 5 times, most recently from 3259db4 to 0481670 Compare September 8, 2023 00:07

Zingam reviewed Sep 8, 2023

View reviewed changes

libcxx/docs/Status/Cxx23Papers.csv Outdated Show resolved Hide resolved

JMazurkiewicz force-pushed the libcxx/ranges/join_with branch from 0481670 to f113229 Compare September 8, 2023 15:11

ldionne assigned var-const and huixie90 and unassigned var-const Sep 13, 2023

ldionne requested a review from huixie90 September 15, 2023 20:55

philnik777 added the ranges Issues related to `<ranges>` label Oct 6, 2023

JMazurkiewicz mentioned this pull request Oct 24, 2023

[libc++] Update status of P2770R0, P2441R2 and P2711R1 papers #70045

Merged

ldionne pushed a commit that referenced this pull request Oct 24, 2023

[libc++] Update status of P2770R0, P2441R2 and P2711R1 (#70045)

e1e0598

This patch adds a mention that the following papers are in progress: * P2770R0: #66033 * P2441R2 and P2711R1: #65536

JMazurkiewicz force-pushed the libcxx/ranges/join_with branch from f113229 to 1835f68 Compare February 2, 2024 23:57

JMazurkiewicz marked this pull request as ready for review February 4, 2024 14:58

JMazurkiewicz requested a review from a team as a code owner February 4, 2024 14:58

JMazurkiewicz force-pushed the libcxx/ranges/join_with branch 3 times, most recently from a84985a to fcdf64a Compare May 14, 2024 14:38

JMazurkiewicz force-pushed the libcxx/ranges/join_with branch 3 times, most recently from 54a741c to a9a1031 Compare May 22, 2024 23:17

JMazurkiewicz force-pushed the libcxx/ranges/join_with branch from a9a1031 to 9406093 Compare June 5, 2024 09:49

JMazurkiewicz added 10 commits January 30, 2025 15:03

Fix unstable ABI tests

6a4a0a4

Merge remote-tracking branch 'upstream/main' into libcxx/ranges/join_…

dfe5543

…with

Target LLVM 21

60264b0

Trigger CI due to GitHub "incident"

36861f1

https://www.githubstatus.com/incidents/nm83zrdky73y

Merge remote-tracking branch 'upstream/main' into libcxx/ranges/join_…

966b3bb

…with

Add links to GitHub in 21.rst

3d54775

Merge remote-tracking branch 'upstream/main' into libcxx/ranges/join_…

10fdb29

…with

Merge remote-tracking branch 'upstream/main' into libcxx/ranges/join_…

30d02a1

…with

Don't use std::is_trivial (deprecated in C++26)

6950e48

Merge remote-tracking branch 'upstream/main' into libcxx/ranges/join_…

41b935b

…with

Merge remote-tracking branch 'upstream/main' into libcxx/ranges/join_…

a0420dc

…with

huixie90 approved these changes May 9, 2025

View reviewed changes

libcxx/docs/ReleaseNotes/21.rst Show resolved Hide resolved

libcxx/include/__ranges/join_with_view.h Outdated Show resolved Hide resolved

libcxx/include/__ranges/join_with_view.h Outdated Show resolved Hide resolved

libcxx/include/__ranges/join_with_view.h Outdated Show resolved Hide resolved

ldionne added pending-ci Merging the PR is only pending completion of CI and removed pending-ci Merging the PR is only pending completion of CI labels May 12, 2025

JMazurkiewicz added 6 commits May 15, 2025 17:36

is_reference_v<range_reference_t<_Base>> => `is_reference_v<_InnerB…

95ea7bc

…ase>` Comment: llvm#65536 (comment)

[[__nodiscard__]] => [[nodiscard]]

8ab29fb

Comment: llvm#65536 (comment)

Add static member function in __sentinel to access priavate member …

7198928

…of `__iterator` Comment: llvm#65536 (comment)

Fix iter_swap.pass.cpp (friendship issues)

6cb18ac

Add static_cast<bool> in end.pass.cpp to avoid truncation warning…

37525db

…s with MSVC

Update synopsis in <ranges> (LWG-4074)

de46d63

Merge remote-tracking branch 'upstream/main' into libcxx/ranges/join_…

fa9e257

…with

JMazurkiewicz force-pushed the libcxx/ranges/join_with branch from e08bf0c to fa9e257 Compare June 11, 2025 10:51

frederick-vs-ja approved these changes Jun 18, 2025

View reviewed changes

huixie90 merged commit 1bb2328 into llvm:main Jun 21, 2025
155 of 181 checks passed

JMazurkiewicz deleted the libcxx/ranges/join_with branch June 21, 2025 14:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[libc++] Implement `views::join_with` #65536

[libc++] Implement `views::join_with` #65536

Uh oh!

JMazurkiewicz commented Sep 6, 2023 •

edited

Loading

Uh oh!

Uh oh!

ldionne commented Sep 15, 2023

Uh oh!

github-actions bot commented Feb 3, 2024 •

edited

Loading

Uh oh!

H-G-Hristov commented May 10, 2024 •

edited

Loading

Uh oh!

JMazurkiewicz commented Apr 14, 2025

Uh oh!

huixie90 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ldionne commented May 12, 2025

Uh oh!

JMazurkiewicz commented May 20, 2025

Uh oh!

frederick-vs-ja left a comment

Uh oh!

huixie90 commented Jun 21, 2025

Uh oh!

Uh oh!

Uh oh!

[libc++] Implement views::join_with #65536

[libc++] Implement views::join_with #65536

Uh oh!

Conversation

JMazurkiewicz commented Sep 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ldionne commented Sep 15, 2023

Uh oh!

github-actions bot commented Feb 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

H-G-Hristov commented May 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JMazurkiewicz commented Apr 14, 2025

Uh oh!

huixie90 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ldionne commented May 12, 2025

Uh oh!

JMazurkiewicz commented May 20, 2025

Uh oh!

frederick-vs-ja left a comment

Choose a reason for hiding this comment

Uh oh!

huixie90 commented Jun 21, 2025

Uh oh!

Uh oh!

Uh oh!

[libc++] Implement `views::join_with` #65536

[libc++] Implement `views::join_with` #65536

JMazurkiewicz commented Sep 6, 2023 •

edited

Loading

github-actions bot commented Feb 3, 2024 •

edited

Loading

H-G-Hristov commented May 10, 2024 •

edited

Loading