[llvm-nm] Fix msan error in llvm-nm/wasm/weak-symbols.yaml.test #65538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happened because we had a section
```
- Index: 3
Kind: DATA
Name: weak_import_data
Flags: [ BINDING_WEAK, UNDEFINED ]
```
Which does not have size. We managed to reproduce it by building llvm under msan with libcxx as a standard library and debug mode with -D_LIBCPP_DEBUG_STRICT_WEAK_ORDERING_CHECK. It called comp(a, a) and full tie detected uninitialized memory
|
Please add a link https://reviews.llvm.org/D158799 to the description. |
MaskRay
approved these changes
Sep 6, 2023
Done |
avillega
pushed a commit
to avillega/llvm-project
that referenced
this pull request
Sep 11, 2023
…#65538) This happened because we had a section ``` - Index: 3 Kind: DATA Name: weak_import_data Flags: [ BINDING_WEAK, UNDEFINED ] ``` Which does not have size. We managed to reproduce it by building llvm under msan with libcxx as a standard library and debug mode with -D_LIBCPP_DEBUG_STRICT_WEAK_ORDERING_CHECK. It called comp(a, a) and full tie detected uninitialized memory This started to happen after https://reviews.llvm.org/D158799
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happened because we had a section
Which does not have size. We managed to reproduce it by building llvm under msan with libcxx as a standard library and debug mode with -D_LIBCPP_DEBUG_STRICT_WEAK_ORDERING_CHECK. It called comp(a, a) and full tie detected uninitialized memory
This started to happen after https://reviews.llvm.org/D158799