[AArch64][SME]Update intrinsic interface for ldr/str #65593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new ACLE PR#225[1] now combines the slice parameters for some builtins. This patch is the llvm#3 of 3 patches to update the interface. [1]https://github.com/ARM-software/acle/pull/225/files
CarolineConcatto
requested review from
dtemirbulatov,
bryanpkc and
sdesmalen-arm
github-actions
bot
added
clang:frontend
sdesmalen-arm
approved these changes
Sep 12, 2023
| @@ -216,9 +216,9 @@ void test_range_0_15(svbool_t pg, void *ptr) { | |||
| SVE_ACLE_FUNC(svst1_ver_vnum_za8,,,)(0, -1, 16, pg, ptr, 1); | |||
|
|
|||
| // expected-error@+1 {{argument value 16 is outside the valid range [0, 15]}} | |||
| SVE_ACLE_FUNC(svldr_vnum_za,,,)(-1, 16, ptr); | |||
| SVE_ACLE_FUNC(svldr_vnum_za,,,)(-1, ptr, 16); | |||
There was a problem hiding this comment.
Not something to fix in this patch, but we shouldn't be adding limits to the vnum parameter, or even require it to be a constant/immediate, because the SVE _vnum intrinsics also don't require this.
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
The new ACLE PR#225[1] now combines the slice parameters for some builtins. [1]https://github.com/ARM-software/acle/pull/225/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new ACLE PR#225[1] now combines the slice parameters for some builtins. This patch is the #3 of 3 patches to update the interface.
[1]https://github.com/ARM-software/acle/pull/225/files