[libc++] Refactor node creation and destruction in list and forward_list #65614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
libc++
EricWF
approved these changes
Sep 8, 2023
The UB fixes are the ones I am picking up in https://reviews.llvm.org/D101206. These fixes are about ensuring that we begin and end the lifetime of node classes, which are currently never created. We allocate the nodes and then we construct their various members individually, but we never actually call their constructor or destructor. |
ldionne
force-pushed
the
review/refactor-list-nodes
branch
2 times, most recently
from
86063a0 to
16c3d05
Compare
This removes a lot of code duplication, makes the code simpler and prepares the terrain for https://reviews.llvm.org/D101206, which will fix some UB in the node-based containers. This also allows removing the dependency of list and forward_list on unique_ptr by using __allocation_guard instead.
ldionne
force-pushed
the
review/refactor-list-nodes
branch
from
16c3d05 to
95b2e16
Compare
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
…ist (llvm#65614) This removes a lot of code duplication, makes the code simpler and prepares the terrain for https://reviews.llvm.org/D101206, which will fix some UB in the node-based containers. This also allows removing the dependency of list and forward_list on unique_ptr by using __allocation_guard instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a lot of code duplication, makes the code simpler and prepares the terrain for https://reviews.llvm.org/D101206, which will fix some UB in the node-based containers.
This also allows removing the dependency of list and forward_list on unique_ptr by using __allocation_guard instead.