[clang][dataflow] Remove RecordValue.getLog() usage in HTMLLogger #65645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can dump the same information from RecordStorageLocation. Tested the behavior before and after patch, that generates the field values in the HTML in both cases (And also made sure if we remove the code it goes away)
github-actions
bot
added
the
clang:dataflow
|
@martinboehme @Xazax-hun @ymand if anyone can review this small patch that removes one more dependency on RecordValue.getLoc()... thanks! |
Xazax-hun
approved these changes
Sep 7, 2023
|
Can you add a screenshot of what this looks like after the change? |
|
Here's the screenshot for a simple code snippet You can see some more screenshots here: |
Thanks for this -- looks great! Just wanted to make sure the output makes sense in context. |
martinboehme
approved these changes
Sep 12, 2023
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
…vm#65645) We can dump the same information from RecordStorageLocation. Tested the behavior before and after patch, that generates the field values in the HTML in both cases (and also made sure that removing the relevant code makes the field values in the HTML go away)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can dump the same information from RecordStorageLocation.
Tested the behavior before and after patch, that generates the field values in the HTML
in both cases (and also made sure that removing the relevant code makes the field values
in the HTML go away)