Skip to content

[LAA] Improve the output remark for LoopVectorize #65832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Conversation

vfdff
Copy link
Contributor

@vfdff vfdff commented Sep 9, 2023

Don't report 'Use #pragma loop distribute(enable) to allow loop
distribution' when we already add #pragma clang loop distribute(enable)

Fixes #64637

@vfdff vfdff requested review from a team as code owners September 9, 2023 05:01
@github-actions github-actions bot added backend:AArch64 llvm:globalisel llvm:analysis Includes value tracking, cost tables and constant folding labels Sep 9, 2023
@vfdff vfdff requested review from nikic, fhahn and david-arm and removed request for a team September 9, 2023 05:04
Don't report 'Use #pragma loop distribute(enable) to allow loop
distribution' when we already add #pragma clang loop distribute(enable)

Fixes llvm#64637
Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vfdff vfdff merged commit 76c6a8b into llvm:main Sep 16, 2023
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
Don't report 'Use #pragma loop distribute(enable) to allow loop
distribution' when we already add #pragma clang loop distribute(enable)

Fixes llvm#64637
@fhahn
Copy link
Contributor

fhahn commented Sep 19, 2023

That's great, thanks @vfdff!

zahiraam pushed a commit to tahonermann/llvm-project that referenced this pull request Oct 24, 2023
Don't report 'Use #pragma loop distribute(enable) to allow loop
distribution' when we already add #pragma clang loop distribute(enable)

Fixes llvm#64637
zahiraam pushed a commit to tahonermann/llvm-project that referenced this pull request Oct 24, 2023
Don't report 'Use #pragma loop distribute(enable) to allow loop
distribution' when we already add #pragma clang loop distribute(enable)

Fixes llvm#64637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:AArch64 llvm:analysis Includes value tracking, cost tables and constant folding llvm:globalisel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[remark] the pass-analysis result inconsistent with the input source
3 participants