Skip to content

[InstCombine] Fix transforms of two select patterns #65845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2023

Conversation

dtcxzyw
Copy link
Member

@dtcxzyw dtcxzyw commented Sep 9, 2023

This patch fixes transforms of select (~a | c), a, b and select (c & b), a, b as discussed in D158983.
Alive2: https://alive2.llvm.org/ce/z/ft6TDw

@dtcxzyw dtcxzyw requested review from nikic and goldsteinn September 9, 2023 08:59
@dtcxzyw dtcxzyw requested a review from a team as a code owner September 9, 2023 08:59
@dtcxzyw dtcxzyw added the llvm:instcombine Covers the InstCombine, InstSimplify and AggressiveInstCombine passes label Sep 10, 2023
@dtcxzyw dtcxzyw requested a review from goldsteinn September 17, 2023 12:30
Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtcxzyw dtcxzyw merged commit 1679b20 into llvm:main Sep 17, 2023
@dtcxzyw dtcxzyw deleted the select-and-or branch September 17, 2023 17:28
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
This patch fixes transforms of `select (~a | c), a, b` and `select (c &
b), a, b` as discussed in [D158983](https://reviews.llvm.org/D158983).
Alive2: https://alive2.llvm.org/ce/z/ft6TDw
zahiraam pushed a commit to tahonermann/llvm-project that referenced this pull request Oct 24, 2023
This patch fixes transforms of `select (~a | c), a, b` and `select (c &
b), a, b` as discussed in [D158983](https://reviews.llvm.org/D158983).
Alive2: https://alive2.llvm.org/ce/z/ft6TDw
zahiraam pushed a commit to tahonermann/llvm-project that referenced this pull request Oct 24, 2023
This patch fixes transforms of `select (~a | c), a, b` and `select (c &
b), a, b` as discussed in [D158983](https://reviews.llvm.org/D158983).
Alive2: https://alive2.llvm.org/ce/z/ft6TDw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm:instcombine Covers the InstCombine, InstSimplify and AggressiveInstCombine passes llvm:transforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants