[AMDGPU] SILowerI1Copies: clear kill flags on COPY #65883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsenm
reviewed
Sep 10, 2023
| %16:vgpr_32 = COPY $vgpr0 | ||
| %19:sreg_32 = S_MOV_B32 0 | ||
| %20:sreg_32 = V_CMP_NE_U32_e64 %16, %19, implicit $exec | ||
| %21:sgpr_32 = S_MOV_B32 0 |
There was a problem hiding this comment.
Can you run this through -run-pass=none to compact the register numbers
| @@ -708,6 +708,9 @@ bool SILowerI1Copies::lowerCopiesToI1() { | |||
| .addImm(0); | |||
| MI.getOperand(1).setReg(TmpReg); | |||
| SrcReg = TmpReg; | |||
| } else { | |||
| // SrcReg needs to be live beyond copy. | |||
| MI.clearKillInfo(); | |||
There was a problem hiding this comment.
Don't you know the exact operand?
arsenm
approved these changes
Sep 10, 2023
Clear kill flags on COPY source as it will be reused.
perlfu
force-pushed
the
fix-si-lower-i1-copies-kills
branch
from
8ceed89 to
4afb8e3
Compare
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
Clear kill flags on COPY source as it will be reused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear kill flags on COPY source as it will be reused.