Skip to content

workflows/pr-subscriber: Handle libc++ and libc++abi labels #66029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

tstellar
Copy link
Collaborator

No description provided.

@tstellar tstellar changed the title workflows/pr-subscriber: Handle libc++ and libc++abi tags workflows/pr-subscriber: Handle libc++ and libc++abi labels Sep 11, 2023
@tstellar tstellar requested review from ldionne and Endilll September 11, 2023 23:35
Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would you prefer instead that we rename the labels to libcxx and libcxxabI?

@tstellar
Copy link
Collaborator Author

LGTM. Would you prefer instead that we rename the labels to libcxx and libcxxabI?

That's the other option, but people on Discord expressed a preference to keep the current label names.

@tstellar tstellar merged commit cff72d7 into llvm:main Sep 12, 2023
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants