Skip to content

[tooling/include-mapping] Add missing localtime_r symbols #66091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

hokein
Copy link
Collaborator

@hokein hokein commented Sep 12, 2023

Fixes #64587.

@hokein hokein requested a review from a team as a code owner September 12, 2023 14:22
@hokein hokein requested a review from kadircet September 12, 2023 14:22
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Sep 12, 2023
@llvmbot
Copy link
Member

llvmbot commented Sep 12, 2023

@llvm/pr-subscribers-clang

Changes

Fixes #64587.

Full diff: https://github.com/llvm/llvm-project/pull/66091.diff

1 Files Affected:

  • (modified) clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc (+10)
diff --git a/clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc b/clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc
index 165c1fc2eebc2c3..0d351d688a3296c 100644
--- a/clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc
+++ b/clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc
@@ -367,6 +367,16 @@ SYMBOL(any_cast, std::, )
 SYMBOL(div, std::, )
 SYMBOL(abort, std::, )
 
+// These are C symbols that are not under std namespace.
+SYMBOL(localtime_r, None, )
+SYMBOL(localtime_r, None, )
+SYMBOL(localtime_s, None, )
+SYMBOL(localtime_s, None, )
+SYMBOL(gmtime_r, None, )
+SYMBOL(gmtime_r, None, )
+SYMBOL(gmtime_s, None, )
+SYMBOL(gmtime_s, None, )
+
 // The std::placeholder symbols (_1, ..., _N) are listed in the cppreference
 // placeholder.html, but the index only contains a single entry with "_1, _2, ..., _N"
 // text, which are not handled by the script.

Copy link
Member

@kadircet kadircet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hokein hokein merged commit 80db833 into llvm:main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

misc-include-cleaner false positive for localtime_r
3 participants