Skip to content

[Attributor] New attribute to identify what byte ranges are alive for an allocation #66148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

vidsinghal
Copy link
Contributor

Changes the size of allocations automatically.
For now, implements the case when a single range from start of the allocation is alive and the allocation can be reduced.

@vidsinghal vidsinghal requested a review from a team as a code owner September 12, 2023 21:39
@vidsinghal vidsinghal changed the title [Attributor] New attribute to identify what byte ranges are alive for an allocation. [Attributor] New attribute to identify what byte ranges are alive for an allocation Sep 12, 2023
@shiltian shiltian requested a review from jdoerfert September 12, 2023 22:40
@vidsinghal vidsinghal force-pushed the vidhush_attributor branch 6 times, most recently from 72abe39 to d40522c Compare September 20, 2023 20:15
@vidsinghal vidsinghal force-pushed the vidhush_attributor branch 4 times, most recently from fc82fad to d30f3e0 Compare October 4, 2023 22:29
@vidsinghal
Copy link
Contributor Author

@shiltian, @jhuber6 , @sstefan1 it would be great if you could provide some comments on this PR.

@vidsinghal vidsinghal force-pushed the vidhush_attributor branch 2 times, most recently from b3f6e6c to df970b9 Compare October 15, 2023 03:53
@vidsinghal vidsinghal requested a review from jhuber6 October 15, 2023 04:28
@vidsinghal vidsinghal requested a review from jdoerfert October 15, 2023 04:29
@vidsinghal vidsinghal force-pushed the vidhush_attributor branch 3 times, most recently from 09341e7 to b771b54 Compare October 19, 2023 03:18
Copy link
Contributor

@shiltian shiltian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch is in a descent shape now.

@vidsinghal vidsinghal force-pushed the vidhush_attributor branch 3 times, most recently from 992e925 to 7c80fa4 Compare October 20, 2023 01:03
Copy link
Member

@jdoerfert jdoerfert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last comments are minor, should be good to be merged after

@vidsinghal vidsinghal requested a review from jdoerfert October 26, 2023 03:09
@vidsinghal vidsinghal force-pushed the vidhush_attributor branch 4 times, most recently from f58753a to 5e92f24 Compare October 29, 2023 03:57
… an allocation

Changes the size of allocations automatically.
Only implements the case when a single range from start of the allocation is alive.

Differential Revision: https://reviews.llvm.org/D157068
@jdoerfert jdoerfert merged commit 754b93e into llvm:main Nov 11, 2023
zahiraam pushed a commit to zahiraam/llvm-project that referenced this pull request Nov 20, 2023
… an allocation (llvm#66148)

Changes the size of allocations automatically.
For now, implements the case when a single range from start of the
allocation is alive and the allocation can be reduced.
Guzhu-AMD pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Nov 23, 2023
Local branch amd-gfx 7ff9492 Merged main:64f62de96609 into amd-gfx:b47928a70477
Remote branch main 754b93e [Attributor] New attribute to identify what byte ranges are alive for an allocation (llvm#66148)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants