[Interpreter] Add initialization of array members #66172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cor3ntin
added
the
clang:frontend
cor3ntin
removed
the
clang:frontend
|
Is there anyone who can review this, as it seems, there was nothing going on in that area for quite some time... |
|
@yubingex007-a11y Can you review this? It seems like you did one of the most recent changes to the respective files |
|
Thanks @lhames . I don’t have commit access, can you land this patch for me? |
i didn't see my commit in git log. can you invite someone else. i am not familiar with the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the interpreter does not initialize
undefconstants of aggregate types correctly (with respect to arrays).The initialization of the array elements is skipped although it is valid to directly write to them. Instructions like
insertvalue {i32, [4 x i32]} undef, i32 1, 1, 2therefore lead to a crash.This is fixed by initializing array values just as fixed-size vectors or structs.