Skip to content

[asan][ubsan] Enable testing with internal symbolizer #66257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

vitalybuka
Copy link
Collaborator

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Sep 13, 2023

@llvm/pr-subscribers-compiler-rt-sanitizer

Changes None -- Full diff: https://github.com//pull/66257.diff

3 Files Affected:

  • (modified) compiler-rt/lib/asan/CMakeLists.txt (+1)
  • (modified) compiler-rt/lib/ubsan/CMakeLists.txt (+2-4)
  • (modified) compiler-rt/test/sanitizer_common/TestCases/demangle_internal.cpp (+1-1)
diff --git a/compiler-rt/lib/asan/CMakeLists.txt b/compiler-rt/lib/asan/CMakeLists.txt
index 1bfc6f0c5e37d84..bc5fe0be120f8d7 100644
--- a/compiler-rt/lib/asan/CMakeLists.txt
+++ b/compiler-rt/lib/asan/CMakeLists.txt
@@ -216,6 +216,7 @@ else()
     RTSanitizerCommonLibc
     RTSanitizerCommonCoverage
     RTSanitizerCommonSymbolizer
+    RTSanitizerCommonSymbolizerInternal
     RTLSanCommon
     RTUbsan)
 
diff --git a/compiler-rt/lib/ubsan/CMakeLists.txt b/compiler-rt/lib/ubsan/CMakeLists.txt
index 93730561523a94c..2031726afe0b59d 100644
--- a/compiler-rt/lib/ubsan/CMakeLists.txt
+++ b/compiler-rt/lib/ubsan/CMakeLists.txt
@@ -207,8 +207,7 @@ else()
               RTSanitizerCommonLibc
               RTSanitizerCommonCoverage
               RTSanitizerCommonSymbolizer
-              # FIXME: Some wrong with C++ demangling.
-              # RTSanitizerCommonSymbolizerInternal
+              RTSanitizerCommonSymbolizerInternal
               RTUbsan
               RTUbsan_standalone
               RTInterception
@@ -253,8 +252,7 @@ else()
                 RTSanitizerCommonLibc
                 RTSanitizerCommonCoverage
                 RTSanitizerCommonSymbolizer
-                # FIXME: Some wrong with C++ demangling.
-                # RTSanitizerCommonSymbolizerInternal
+                RTSanitizerCommonSymbolizerInternal
                 RTUbsan
                 RTUbsan_cxx
                 RTUbsan_standalone
diff --git a/compiler-rt/test/sanitizer_common/TestCases/demangle_internal.cpp b/compiler-rt/test/sanitizer_common/TestCases/demangle_internal.cpp
index 3202fc17aea7d63..6ec1851275eb135 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/demangle_internal.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/demangle_internal.cpp
@@ -3,7 +3,7 @@
 // REQUIRES: internal_symbolizer
 
 // FIXME: link internal_symbolizer.
-// XFAIL: asan, hwasan, ubsan
+// XFAIL: hwasan
 
 #include <algorithm>
 #include <assert.h>

@vitalybuka vitalybuka merged commit 25e8105 into llvm:main Sep 13, 2023
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
Guzhu-AMD pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Sep 21, 2023
Local branch amd-gfx 0d570d0 Merged main:c199f7dc62f3 into amd-gfx:124b4cad343b
Remote branch main 25e8105 [asan][ubsan] Enable testing with internal symbolizer (llvm#66257)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants