[flang][CMake] CYGWIN requires _GNU_SOURCE to be defined. #66747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiling flang on CYGWIN prints this error message on the console:
llvm-project/flang/include/flang/Parser/char-block.h: In member function ‘std::string Fortran::parser::CharBlock::NULTerminatedToString() const’:
llvm-project/flang/include/flang/Parser/char-block.h:106:26: error: ‘strnlen’ was not declared in this scope; did you mean ‘strlen’?
106 | /*not in std::*/ strnlen(interval_.start(), interval_.size())};
| ^~~~~~~
| strlen
strnlen() exists into NEWLIB, but it requires to define _GNU_SOURCE macro somewhere for having its prototype available.
This patch adds this definition, by using the same code written here:
https://github.com/llvm/llvm-project/blob/53602e6193d98b1e814b76a27e99ef7e18c9769c/third-party/benchmark/CMakeLists.txt#L230
carlo-bramini
changed the title
carlo-bramini
changed the title
|
Closing as resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling flang on CYGWIN prints this error message on the console:
strnlen()exists into NEWLIB, but it requires to define_GNU_SOURCEmacro somewhere for having its prototype available.This patch adds this definition, by using the same code written here:
llvm-project/third-party/benchmark/CMakeLists.txt
Line 230 in 53602e6