Skip to content

workflows/release-tasks: Setup FileCheck and not for release-lit #66799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2023
+14 −3
Merged

workflows/release-tasks: Setup FileCheck and not for release-lit #66799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions .github/workflows/release-tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,24 @@ jobs:
- name: Checkout LLVM
uses: actions/checkout@v4

- name: Setup Cpp
uses: aminya/setup-cpp@v1
with:
compiler: llvm-16.0.6
cmake: true
ninja: true

- name: Install dependencies
run: sudo apt-get install -y python3-setuptools
run: |
sudo apt-get update
sudo apt-get install -y python3-setuptools python3-psutil

- name: Test lit
run: |
cd llvm/utils/lit
python3 lit.py tests
mkdir build && cd build
export FILECHECK_OPTS='-dump-input-filter=all -vv -color'
cmake ../llvm -DCMAKE_BUILD_TYPE=Release -G Ninja
ninja -v -j $(nproc) check-lit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make debugging any failed tests easier, would you please consider adding the following to the environment when running check-lit?

export FILECHECK_OPTS='-dump-input-filter=all -vv -color'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, I realize I don't know that I understand the context. If this is run manually and can easily be re-run with different environment variables, then the person running it should decide whether to make this change. Otherwise, defaulting to verbosity would be helpful for whoever has to understand test failures.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't hurt to have extra verbosity.
Running this is not complex, but does require a specific setup.
I added included this suggestion in my last commit.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


- name: Package lit
run: |
Expand Down