Skip to content

[clang-analysis]Fix false positive in mutation check when using pointer to member function #66846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 25, 2023
Merged

[clang-analysis]Fix false positive in mutation check when using pointer to member function #66846

merged 7 commits into from
Sep 25, 2023

Conversation

HerrCai0907
Copy link
Contributor

Fixes: #66204

@llvmbot llvmbot added clang Clang issues not falling into any other category clang-tidy clang:dataflow Clang Dataflow Analysis framework - https://clang.llvm.org/docs/DataFlowAnalysisIntro.html clang:analysis labels Sep 20, 2023
PiotrZSL
PiotrZSL approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@PiotrZSL PiotrZSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clang-tidy part looking fine for me.

@HerrCai0907 HerrCai0907 requested review from cor3ntin, AaronBallman and a team September 20, 2023 13:17
@ymand ymand removed the clang:dataflow Clang Dataflow Analysis framework - https://clang.llvm.org/docs/DataFlowAnalysisIntro.html label Sep 20, 2023
EugeneZelenko
EugeneZelenko reviewed Sep 21, 2023
View reviewed changes
@llvmbot llvmbot added the clang:dataflow Clang Dataflow Analysis framework - https://clang.llvm.org/docs/DataFlowAnalysisIntro.html label Sep 21, 2023
@HerrCai0907 HerrCai0907 removed the clang:dataflow Clang Dataflow Analysis framework - https://clang.llvm.org/docs/DataFlowAnalysisIntro.html label Sep 21, 2023
mzyKi
mzyKi reviewed Sep 25, 2023
View reviewed changes
mzyKi
mzyKi reviewed Sep 25, 2023
View reviewed changes
@llvmbot llvmbot added the clang:dataflow Clang Dataflow Analysis framework - https://clang.llvm.org/docs/DataFlowAnalysisIntro.html label Sep 25, 2023
@HerrCai0907 HerrCai0907 merged commit feb7b19 into llvm:main Sep 25, 2023
@HerrCai0907 HerrCai0907 deleted the 66204-false-positive-for-clang-tidy-rule-misc-const-correctness branch September 25, 2023 23:40
Guzhu-AMD pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Sep 28, 2023
Merged main:feb7b1914d51 into amd-gfx:e2e3938ffce3
9e0aff5 
Local branch amd-gfx e2e3938 Merged main:ea7157ff4f58 into amd-gfx:d7036c5ed4aa
Remote branch main feb7b19 [clang-analysis]Fix false positive in mutation check when using pointer to member function (llvm#66846)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EugeneZelenko EugeneZelenko EugeneZelenko left review comments

@mzyKi mzyKi mzyKi left review comments

@PiotrZSL PiotrZSL PiotrZSL approved these changes

@cor3ntin cor3ntin Awaiting requested review from cor3ntin

@AaronBallman AaronBallman Awaiting requested review from AaronBallman

Assignees
No one assigned
Labels
clang:analysis clang:dataflow Clang Dataflow Analysis framework - https://clang.llvm.org/docs/DataFlowAnalysisIntro.html clang Clang issues not falling into any other category clang-tidy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

false positive for clang-tidy rule 'misc-const-correctness'
6 participants
@HerrCai0907 @PiotrZSL @EugeneZelenko @mzyKi @ymand @llvmbot