[clang][Interp] Zero-init remaining string literal elements #66862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbaederr
requested review from
cor3ntin,
AaronBallman,
shafik and
erichkeane
llvmbot
added
clang
|
Ping |
erichkeane
approved these changes
Sep 28, 2023
shafik
reviewed
Sep 28, 2023
| static_assert(a.c[0] == 'a', ""); | ||
| static_assert(a.c[1] == 'b', ""); | ||
| static_assert(a.c[2] == 'c', ""); | ||
| static_assert(a.c[3] == '\0', ""); |
There was a problem hiding this comment.
Shouldn't we just test all the bytes? It is small enough.
There was a problem hiding this comment.
Should we also test wide string literals etc?
| @@ -858,8 +858,8 @@ bool ByteCodeExprGen<Emitter>::VisitStringLiteral(const StringLiteral *E) { | |||
|
|
|||
| // If the initializer string is too long, a diagnostic has already been | |||
| // emitted. Read only the array length from the string literal. | |||
| unsigned N = | |||
| std::min(unsigned(CAT->getSize().getZExtValue()), E->getLength()); | |||
| unsigned ArraySize = CAT->getSize().getZExtValue(); | |||
There was a problem hiding this comment.
So getZExtValue() returns uint64_t yet we are using unsigned. I know this is already an existing problem that we make varying assumptions in different places but I am wondering what the long-term plan is for this this. Forgive me if I have asked this question in another context and I just forgot.
There was a problem hiding this comment.
It's a bit tricky since StringLiteral::getLength() returns unsigned again, so we can't use the extra bytes anyway and need to cast to unsigned for the std::min().
tbaederr
force-pushed
the
zero-fill-strings
branch
from
270735d to
f2b9dec
Compare
shafik
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.