libclc: generic: add half implementation for erf/erfc #66901
Merged
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libclc does not have a half implementation for erf/erfc Add one based on the float implementation by extending the input and truncating the output.
|
@kpet @alan-baker could you review this PR please? |
kpet
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Looks infinitely better than the absence of FP16 implementation we currently have. I have not tried to think through rounding and other detailed considerations. The OpenCL CTS currently does not cover FP16 variants of these functions but I believe this is in the works. We can revisit the implementation if the conformance tests reveal issues.
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
libclc does not have a half implementation for erf/erfc Add one based on the float implementation by extending the input and truncating the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libclc does not have a half implementation for erf/erfc
Add one based on the float implementation by extending the input and truncating the output.