libclc: clspv: update gen_convert.cl for clspv #66902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kpet @alan-baker could you review this PR please? |
rjodinchr
force-pushed
the
pr/convert
branch
from
2a2355d to
67e347f
Compare
rjodinchr
changed the title
|
✅ With the latest revision this PR passed the Python code formatter. |
rjodinchr
force-pushed
the
pr/convert
branch
2 times, most recently
from
a6146bb to
8d2b49e
Compare
kpet
reviewed
Mar 14, 2024
Add a clspv switch in gen_convert.cl This is needed as Vulkan SPIR-V does not respect the assumptions needed to have the generic convert.cl compliant on many platforms. It is needed because of the conversion of TYPE_MAX and TYPE_MIN. Depending on the platform the behaviour can vary, but most of them just do not convert correctly those 2 values. Because of that, we also need to avoid having explicit function for simple conversions because it allows llvm to optimise the code, thus removing some of the added checks that are in fact needed.
kpet
approved these changes
Mar 14, 2024
rjodinchr
added a commit
to rjodinchr/clspv
that referenced
this pull request
Mar 15, 2024
Build libclc as part of the build system rather than relying on a checked-in bitcode file. This somewhat increases the duration of the build as clang, opt, etc are built as dependencies. Update llvm dep to get llvm/llvm-project#66902 Ref google#826 Based on google#903
rjodinchr
added a commit
to rjodinchr/clspv
that referenced
this pull request
Mar 15, 2024
Build libclc as part of the build system rather than relying on a checked-in bitcode file. This somewhat increases the duration of the build as clang, opt, etc are built as dependencies. Update llvm dep to get llvm/llvm-project#66902 Ref google#826 Based on google#903
rjodinchr
added a commit
to rjodinchr/clspv
that referenced
this pull request
Mar 15, 2024
Build libclc as part of the build system rather than relying on a checked-in bitcode file. This somewhat increases the duration of the build as clang, opt, etc are built as dependencies. Update llvm dep to get llvm/llvm-project#66902 Ref google#826 Based on google#903
rjodinchr
added a commit
to rjodinchr/clspv
that referenced
this pull request
Mar 15, 2024
Build libclc as part of the build system rather than relying on a checked-in bitcode file. This somewhat increases the duration of the build as clang, opt, etc are built as dependencies. Update llvm dep to get llvm/llvm-project#66902 Ref google#826 Based on google#903
rjodinchr
added a commit
to rjodinchr/clspv
that referenced
this pull request
Mar 15, 2024
Build libclc as part of the build system rather than relying on a checked-in bitcode file. This somewhat increases the duration of the build as clang, opt, etc are built as dependencies. Update llvm dep to get llvm/llvm-project#66902 Ref google#826 Based on google#903
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a clspv switch in gen_convert.cl
This is needed as Vulkan SPIR-V does not respect the assumptions
needed to have the generic convert.cl compliant on many platforms.
It is needed because of the conversion of TYPE_MAX and
TYPE_MIN. Depending on the platform the behaviour can vary, but most
of them just do not convert correctly those 2 values.
Because of that, we also need to avoid having explicit function for
simple conversions because it allows llvm to optimise the code, thus
removing some of the added checks that are in fact needed.