Skip to content

[lld][COFF][LTO] Implement /lldemit:llvm option #66964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lld/COFF/Config.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ enum class ExportSource {
ModuleDefinition,
};

enum class EmitKind { Obj, LLVM };

// Represents an /export option.
struct Export {
StringRef name; // N in /export:N or /export:E=N
Expand Down Expand Up @@ -311,6 +313,7 @@ struct Configuration {
bool pseudoRelocs = false;
bool stdcallFixup = false;
bool writeCheckSum = false;
EmitKind emit = EmitKind::Obj;
};

} // namespace lld::coff
Expand Down
14 changes: 13 additions & 1 deletion lld/COFF/Driver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1852,6 +1852,17 @@ void LinkerDriver::linkerMain(ArrayRef<const char *> argsArr) {
if (args.hasArg(OPT_lldsavetemps))
config->saveTemps = true;

// Handle /lldemit
if (auto *arg = args.getLastArg(OPT_lldemit)) {
StringRef s = arg->getValue();
if (s == "obj")
config->emit = EmitKind::Obj;
else if (s == "llvm")
config->emit = EmitKind::LLVM;
else
error("/lldemit: unknown option: " + s);
}

// Handle /kill-at
if (args.hasArg(OPT_kill_at))
config->killAt = true;
Expand Down Expand Up @@ -2395,7 +2406,8 @@ void LinkerDriver::linkerMain(ArrayRef<const char *> argsArr) {
// If -thinlto-index-only is given, we should create only "index
// files" and not object files. Index file creation is already done
// in addCombinedLTOObject, so we are done if that's the case.
if (config->thinLTOIndexOnly)
// Likewise, don't emit object files for other /lldemit options.
if (config->emit != EmitKind::Obj || config->thinLTOIndexOnly)
return;

// If we generated native object files from bitcode files, this resolves
Expand Down
9 changes: 9 additions & 0 deletions lld/COFF/LTO.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,15 @@ lto::Config BitcodeCompiler::createConfig() {
c.RunCSIRInstr = ctx.config.ltoCSProfileGenerate;
c.PGOWarnMismatch = ctx.config.ltoPGOWarnMismatch;

if (ctx.config.emit == EmitKind::LLVM) {
c.PostInternalizeModuleHook = [this](size_t task, const Module &m) {
if (std::unique_ptr<raw_fd_ostream> os =
openLTOOutputFile(ctx.config.outputFile))
WriteBitcodeToFile(m, *os, false);
return false;
};
}

if (ctx.config.saveTemps)
checkError(c.addSaveTemps(std::string(ctx.config.outputFile) + ".",
/*UseInputModulePath*/ true));
Expand Down
1 change: 1 addition & 0 deletions lld/COFF/Options.td
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ defm demangle : B<"demangle",
def include_optional : Joined<["/", "-", "/?", "-?"], "includeoptional:">,
HelpText<"Add symbol as undefined, but allow it to remain undefined">;
def kill_at : F<"kill-at">;
def lldemit : P<"lldemit", "Specify output type">;
def lldmingw : F<"lldmingw">;
def noseh : F<"noseh">;
def osversion : P_priv<"osversion">;
Expand Down
14 changes: 14 additions & 0 deletions lld/test/COFF/lto-emit-llvm.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
; REQUIRES: x86
; RUN: llvm-as -o %T/lto.obj %s

; RUN: lld-link /lldemit:llvm /out:%T/lto.bc /entry:main /subsystem:console %T/lto.obj
; RUN: llvm-dis %T/lto.bc -o - | FileCheck %s

; CHECK: define void @main()

target datalayout = "e-m:w-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-pc-windows-msvc"

define void @main() {
ret void
}