[MLIR][OpenACC][NFC] Make OpenACC dialect include absolute #67271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-openacc @llvm/pr-subscribers-mlir-openacc ChangesMLIR TableGen definitions usually use absolute includes instead of relative includes. This patch makes it consistent for OpenACC operation definations. Full diff: https://github.com/llvm/llvm-project/pull/67271.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/OpenACC/OpenACCOpsTypes.td b/mlir/include/mlir/Dialect/OpenACC/OpenACCOpsTypes.td
index 41a18e4d206d492..4a930ad94c3f175 100644
--- a/mlir/include/mlir/Dialect/OpenACC/OpenACCOpsTypes.td
+++ b/mlir/include/mlir/Dialect/OpenACC/OpenACCOpsTypes.td
@@ -14,7 +14,7 @@
#define OPENACC_OPS_TYPES
include "mlir/IR/AttrTypeBase.td"
-include "OpenACCBase.td"
+include "mlir/Dialect/OpenACC/OpenACCBase.td"
class OpenACC_Type<string name, string typeMnemonic> : TypeDef<OpenACC_Dialect, name> {
let mnemonic = typeMnemonic;
|
Guzhu-AMD
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Sep 28, 2023
Local branch amd-gfx d7d5170 Merged main:4c59f809c926 into amd-gfx:1347e75c19d8 Remote branch main f7bf99f [MLIR][OpenACC][NFC] Make OpenACC dialect include absolute (llvm#67271)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MLIR TableGen definitions usually use absolute includes instead of relative includes. This patch makes it consistent for OpenACC operation definations.