[Flang][Driver][OpenMP][Test] Modify one omp-driver-offload.f90 command to not incorrectly expect a single output #67335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to not incorrectly expect a single output The test command which tests offloading to multiple device architectures expects multiple outputs, however, the test as written with the -o expects a single output result. This change modifies it to not expect a single output, which allows the command to succeed and allow the removal of the not prefix.
agozillon
requested review from
skatrak,
jsjodin,
banach-space,
kiranchandramohan,
raghavendhra,
DominikAdamski,
dpalermo,
NimishMishra,
TIFitis and
kiranktp
|
@llvm/pr-subscribers-flang-openmp @llvm/pr-subscribers-flang-driver ChangesThe test command which tests offloading to multiple device architectures expects multiple outputs, however, the test as written with the -o expects a single output result. This change modifies it to not expect a single output, which allows the command to succeed and allow the removal of the not prefix. Full diff: https://github.com/llvm/llvm-project/pull/67335.diff 1 Files Affected:
diff --git a/flang/test/Driver/omp-driver-offload.f90 b/flang/test/Driver/omp-driver-offload.f90
index 74ed0f9006e81c3..ba68f76e7a458aa 100644
--- a/flang/test/Driver/omp-driver-offload.f90
+++ b/flang/test/Driver/omp-driver-offload.f90
@@ -33,7 +33,7 @@
! OFFLOAD-HOST-NOT: "-triple" "nvptx64-nvidia-cuda"
! OFFLOAD-HOST-NOT: "{{[^"]*}}flang-new" "-fc1" "-triple" "aarch64-unknown-linux-gnu"
-! RUN: not %flang -S -### %s -o %t 2>&1 \
+! RUN: %flang -S -### %s 2>&1 \
! RUN: -fopenmp --offload-arch=gfx90a --offload-arch=sm_70 --offload-device-only \
! RUN: --target=aarch64-unknown-linux-gnu \
! RUN: | FileCheck %s --check-prefix=OFFLOAD-DEVICE
|
|
windows failure is unrelated to this test change, seems to be a sporadic break of the windows test script |
M4ximumPizza
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test command which tests offloading to multiple device architectures expects multiple outputs, however, the test as written with the -o expects a single output result. This change modifies it to not expect a single output, which allows the command to succeed and allow the removal of the not prefix.