[mlir][Vector] Fix doc generation #67341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The format is `add_mlir_doc(<table gen file> <output md name> <output dir> <command>)` Using the Vector.td files does not work has it does not include the VectorOps.td (so the docs are empty). If the ouput name is not VectorOps.md, the mlir-www site does not find the ops (and instead overwrites it with an empty template).
|
@llvm/pr-subscribers-mlir-vector @llvm/pr-subscribers-mlir ChangesThe format is Using the Vector.td files does not work has it does not include the VectorOps.td (so the docs are empty). If the ouput name is not VectorOps.md, the mlir-www site does not find the ops (and instead overwrites it with an empty template). Full diff: https://github.com/llvm/llvm-project/pull/67341.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Vector/IR/CMakeLists.txt b/mlir/include/mlir/Dialect/Vector/IR/CMakeLists.txt
index 91cbb415140d002..5bbc4c6d2678b34 100644
--- a/mlir/include/mlir/Dialect/Vector/IR/CMakeLists.txt
+++ b/mlir/include/mlir/Dialect/Vector/IR/CMakeLists.txt
@@ -1,5 +1,5 @@
add_mlir_dialect(Vector vector)
-add_mlir_doc(VectorOps Vector Dialects/ -gen-op-doc)
+add_mlir_doc(VectorOps VectorOps Dialects/ -gen-op-doc)
# Add Vector operations
set(LLVM_TARGET_DEFINITIONS VectorOps.td)
|
|
hmm I thought I had pushed this already .. apparently not |
nicolasvasilache
approved these changes
Sep 25, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format is
add_mlir_doc(<table gen file> <output md name> <output dir> <command>)Using the Vector.td file does not work as it does not include VectorOps.td (so the docs are empty). If the output name is not VectorOps.md, the mlir-www site does not find the ops (and instead overwrites it with an empty template).