Skip to content

[NFC][SPIRV] fix missing uppercase for var name #67438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

Keenuts
Copy link
Contributor

@Keenuts Keenuts commented Sep 26, 2023

Typo fix.

@llvmbot
Copy link
Member

llvmbot commented Sep 26, 2023

@llvm/pr-subscribers-backend-spir-v

Changes

Typo fix.


Full diff: https://github.com/llvm/llvm-project/pull/67438.diff

1 Files Affected:

  • (modified) llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp (+3-3)
diff --git a/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp b/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
index 028258d73a3e9cc..035989f2fe571b2 100644
--- a/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
@@ -1299,15 +1299,15 @@ bool SPIRVInstructionSelector::selectExtractElt(Register ResVReg,
 bool SPIRVInstructionSelector::selectGEP(Register ResVReg,
                                          const SPIRVType *ResType,
                                          MachineInstr &I) const {
-  const bool isGEPInBounds = I.getOperand(2).getImm();
+  const bool IsGEPInBounds = I.getOperand(2).getImm();
 
   // OpAccessChain could be used for OpenCL, but the SPIRV-LLVM Translator only
   // relies on PtrAccessChain, so we'll try not to deviate. For Vulkan however,
   // we have to use Op[InBounds]AccessChain.
   const unsigned Opcode = STI.isVulkanEnv()
-                              ? (isGEPInBounds ? SPIRV::OpInBoundsAccessChain
+                              ? (IsGEPInBounds ? SPIRV::OpInBoundsAccessChain
                                                : SPIRV::OpAccessChain)
-                              : (isGEPInBounds ? SPIRV::OpInBoundsPtrAccessChain
+                              : (IsGEPInBounds ? SPIRV::OpInBoundsPtrAccessChain
                                                : SPIRV::OpPtrAccessChain);
 
   auto Res = BuildMI(*I.getParent(), I, I.getDebugLoc(), TII.get(Opcode))

Copy link
Contributor

@iliya-diyachkov iliya-diyachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. It looks good to me.

@Keenuts Keenuts merged commit 7658688 into llvm:main Sep 27, 2023
@Keenuts Keenuts deleted the typo branch September 27, 2023 16:31
legrosbuffle pushed a commit to legrosbuffle/llvm-project that referenced this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants