UpdateTestChecks: squelch warning on SCEV output

[artagnon]

update_analyze_test_checks.py currently outputs a warning when updating a script with the run line:

  $ opt -passes='print<scalar-evolution>'

saying that the script doesn't support its output, when it indeed does, as evidenced by several tests in test/Analysis/ScalarEvolution generated by this script. There is even a test for update_analyze_test_checks that makes sure that SCEV output is supported. Hence, squelch the warning.

While at it, rename the update_analyze_test_checks test from basic.ll to a more explicit scev.ll.

[llvmbot]

@llvm/pr-subscribers-testing-tools

Changes

update_analyze_test_checks.py currently outputs a warning when updating a script with the run line:

  $ opt -passes='print<scalar-evolution>'

saying that the script doesn't support its output, when it indeed does, as evidenced by several tests in test/Analysis/ScalarEvolution generated by this script. There is even a test for update_analyze_test_checks that makes sure that SCEV output is supported. Hence, squelch the warning.

While at it, rename the update_analyze_test_checks test from basic.ll to a more explicit scev.ll.

---

Full diff: https://github.com/llvm/llvm-project/pull/67443.diff

4 Files Affected:

• (renamed) llvm/test/tools/UpdateTestChecks/update_analyze_test_checks/Inputs/scev.ll ()
• (renamed) llvm/test/tools/UpdateTestChecks/update_analyze_test_checks/Inputs/scev.ll.expected ()
• (renamed) llvm/test/tools/UpdateTestChecks/update_analyze_test_checks/scev.test (+3-3)
• (modified) llvm/utils/UpdateTestChecks/common.py (+2-1)

diff --git a/llvm/test/tools/UpdateTestChecks/update_analyze_test_checks/Inputs/basic.ll b/llvm/test/tools/UpdateTestChecks/update_analyze_test_checks/Inputs/scev.ll
similarity index 100%
rename from llvm/test/tools/UpdateTestChecks/update_analyze_test_checks/Inputs/basic.ll
rename to llvm/test/tools/UpdateTestChecks/update_analyze_test_checks/Inputs/scev.ll
diff --git a/llvm/test/tools/UpdateTestChecks/update_analyze_test_checks/Inputs/basic.ll.expected b/llvm/test/tools/UpdateTestChecks/update_analyze_test_checks/Inputs/scev.ll.expected
similarity index 100%
rename from llvm/test/tools/UpdateTestChecks/update_analyze_test_checks/Inputs/basic.ll.expected
rename to llvm/test/tools/UpdateTestChecks/update_analyze_test_checks/Inputs/scev.ll.expected
diff --git a/llvm/test/tools/UpdateTestChecks/update_analyze_test_checks/basic.test b/llvm/test/tools/UpdateTestChecks/update_analyze_test_checks/scev.test
similarity index 51%
rename from llvm/test/tools/UpdateTestChecks/update_analyze_test_checks/basic.test
rename to llvm/test/tools/UpdateTestChecks/update_analyze_test_checks/scev.test
index 78f9646871efb68..413951f14da31b6 100644
--- a/llvm/test/tools/UpdateTestChecks/update_analyze_test_checks/basic.test
+++ b/llvm/test/tools/UpdateTestChecks/update_analyze_test_checks/scev.test
@@ -1,6 +1,6 @@
 ## Basic test checking that update_analyze_test_checks.py works correctly
-# RUN: cp -f %S/Inputs/basic.ll %t.ll && %update_analyze_test_checks %t.ll
-# RUN: diff -u %t.ll %S/Inputs/basic.ll.expected
+# RUN: cp -f %S/Inputs/scev.ll %t.ll && %update_analyze_test_checks %t.ll
+# RUN: diff -u %t.ll %S/Inputs/scev.ll.expected
 ## Check that running the script again does not change the result:
 # RUN: %update_analyze_test_checks %t.ll
-# RUN: diff -u %t.ll %S/Inputs/basic.ll.expected
+# RUN: diff -u %t.ll %S/Inputs/scev.ll.expected
diff --git a/llvm/utils/UpdateTestChecks/common.py b/llvm/utils/UpdateTestChecks/common.py
index 22c05322d9c7dbc..264c4a4aefbf805 100644
--- a/llvm/utils/UpdateTestChecks/common.py
+++ b/llvm/utils/UpdateTestChecks/common.py
@@ -767,7 +767,8 @@ def process_run_line(
             )
             if "analysis" in m.groupdict():
                 analysis = m.group("analysis")
-                if analysis.lower() != "cost model analysis":
+                supported_analyses = {"cost model analysis", "scalar evolution analysis"}
+                if analysis.lower() not in supported_analyses:
                     warn("Unsupported analysis mode: %r!" % (analysis,))
             if func.startswith("stress"):
                 # We only use the last line of the function body for stress tests.

[github-actions]

✅ With the latest revision this PR passed the Python code formatter.

[nikic]

LGTM