Skip to content

[x86] precommit test conversion via update_llc_test_checks.py #67463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

nickdesaulniers
Copy link
Member

I'm looking to update this test; pre-processing it with
update_llc_test_checks.py makes it clearer what I'm changing in #20571.

I'm looking to update this test; pre-processing it with
update_llc_test_checks.py makes it clearer what I'm changing in llvm#20571.
@llvmbot
Copy link
Member

llvmbot commented Sep 26, 2023

@llvm/pr-subscribers-backend-x86

Changes

I'm looking to update this test; pre-processing it with
update_llc_test_checks.py makes it clearer what I'm changing in #20571.


Full diff: https://github.com/llvm/llvm-project/pull/67463.diff

1 Files Affected:

  • (modified) llvm/test/CodeGen/X86/inlineasm-sched-bug.ll (+16-5)
diff --git a/llvm/test/CodeGen/X86/inlineasm-sched-bug.ll b/llvm/test/CodeGen/X86/inlineasm-sched-bug.ll
index b89349696555657..be4d1c29332f778 100644
--- a/llvm/test/CodeGen/X86/inlineasm-sched-bug.ll
+++ b/llvm/test/CodeGen/X86/inlineasm-sched-bug.ll
@@ -1,15 +1,26 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 3
 ; PR13504
 ; RUN: llc -mtriple=i686-- -mcpu=atom < %s | FileCheck %s
 ; Check that treemap is read before the asm statement.
-; CHECK: movl 8(%{{esp|ebp}})
-; CHECK: bsfl
-; CHECK-NOT: movl 8(%{{esp|ebp}})
 
-define i32 @foo(i32 %treemap) nounwind uwtable {
+define i32 @foo(i32 %treemap) nounwind {
+; CHECK-LABEL: foo:
+; CHECK:       # %bb.0: # %entry
+; CHECK-NEXT:    pushl %eax
+; CHECK-NEXT:    movl {{[0-9]+}}(%esp), %eax
+; CHECK-NEXT:    movl %eax, %ecx
+; CHECK-NEXT:    negl %ecx
+; CHECK-NEXT:    andl %eax, %ecx
+; CHECK-NEXT:    movl %ecx, (%esp)
+; CHECK-NEXT:    #APP
+; CHECK-NEXT:    bsfl (%esp), %eax
+; CHECK-NEXT:    #NO_APP
+; CHECK-NEXT:    popl %ecx
+; CHECK-NEXT:    retl
 entry:
   %sub = sub i32 0, %treemap
   %and = and i32 %treemap, %sub
-  %0 = tail call i32 asm "bsfl $1,$0\0A\09", "=r,rm,~{dirflag},~{fpsr},~{flags}"(i32 %and) nounwind
+  %0 = call i32 asm "bsfl $1,$0", "=r,rm"(i32 %and)
   ret i32 %0
 }
 

Copy link
Contributor

@MatzeB MatzeB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@RKSimon RKSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickdesaulniers nickdesaulniers merged commit 2e2c61e into llvm:main Sep 26, 2023
@nickdesaulniers nickdesaulniers deleted the update_test_checks branch September 26, 2023 22:22
legrosbuffle pushed a commit to legrosbuffle/llvm-project that referenced this pull request Sep 29, 2023
…7463)

I'm looking to update this test; pre-processing it with
update_llc_test_checks.py makes it clearer what I'm changing in llvm#20571.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants