Skip to content

[RISCV][GISel] Legalize G_SADDO/G_SSUBO/G_UADDO/G_USUBO. #67615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 30, 2023

Conversation

topperc
Copy link
Collaborator

@topperc topperc commented Sep 27, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 27, 2023

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff 3e87829a8a9ab6a5f62078c590eec09f5024f95f a31b927bbf4650fab5338878d7f9d55e3fb8bcb8 -- llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp
View the diff from clang-format here.
diff --git a/llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp b/llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp
index 562b522dfacd..2a451b3ba5e9 100644
--- a/llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp
+++ b/llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp
@@ -41,8 +41,7 @@ RISCVLegalizerInfo::RISCVLegalizerInfo(const RISCVSubtarget &ST) {
       .widenScalarToNextPow2(0)
       .clampScalar(0, s32, XLenLLT);
 
-  getActionDefinitionsBuilder(
-      {G_UADDE, G_UADDO, G_USUBE, G_USUBO}).lower();
+  getActionDefinitionsBuilder({G_UADDE, G_UADDO, G_USUBE, G_USUBO}).lower();
 
   getActionDefinitionsBuilder({G_SADDO, G_SSUBO}).minScalar(0, XLenLLT).lower();
 

{G_UADDE, G_UADDO, G_USUBE, G_USUBO}).lower();

getActionDefinitionsBuilder({G_SADDO, G_SSUBO})
.lower();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code formatting here seems a little bit weird...the clang-format bot was not happy about this either

Copy link
Contributor

@nitinjohnraj nitinjohnraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@topperc topperc merged commit e39727d into llvm:main Sep 30, 2023
@topperc topperc deleted the pr/gisel-addo-subo branch September 30, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants