[mlir][memref] Fix offset update in emulating narrow type for strided memref #67714
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groverkss
requested review from
antiagainst,
MaheshRavishankar,
qedawkins and
raikonenfnu
|
Looks good to me. Thanks! |
MaheshRavishankar
approved these changes
Sep 28, 2023
legrosbuffle
pushed a commit
to legrosbuffle/llvm-project
that referenced
this pull request
Sep 29, 2023
… memref (llvm#67714) The offset when converting type in emulating narrow types did not account for the offset in strided memrefs. This patch fixes this.
|
I have reverted this commit upon integrating it into IREE and finding that it breaks Vulkan compilation of the model it was targeting to improve. I decided that this was appropriate because I know that the author was working on the affected project, and I believe that this is one of a handful of execution tests for the feature. Feel free to re-apply in the new week with additional triage. |
qedawkins
pushed a commit
to iree-org/llvm-project
that referenced
this pull request
Oct 1, 2023
… strided memref (llvm#67714)" This reverts commit 35ec6ea. Breaks downstream narrow type execution tests.
stellaraccident
added a commit
to iree-org/llvm-project
that referenced
this pull request
Oct 5, 2023
… strided memref (llvm#67714)" This reverts commit 35ec6ea. Breaks downstream narrow type execution tests.
stellaraccident
added a commit
to iree-org/llvm-project
that referenced
this pull request
Oct 5, 2023
… strided memref (llvm#67714)" This reverts commit 35ec6ea. Breaks downstream narrow type execution tests.
stellaraccident
added a commit
to iree-org/llvm-project
that referenced
this pull request
Oct 5, 2023
… strided memref (llvm#67714)" This reverts commit 35ec6ea. Breaks downstream narrow type execution tests.
stellaraccident
added a commit
to iree-org/llvm-project
that referenced
this pull request
Oct 5, 2023
… strided memref (llvm#67714)" This reverts commit 35ec6ea. Breaks downstream narrow type execution tests.
stellaraccident
added a commit
to iree-org/llvm-project
that referenced
this pull request
Oct 5, 2023
… strided memref (llvm#67714)" This reverts commit 35ec6ea. Breaks downstream narrow type execution tests.
Guzhu-AMD
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Oct 12, 2023
Local branch amd-gfx a01f70e Merged main:f88f090a2ef1 into amd-gfx:4e956125f560 Remote branch main 8d20310 Revert "[mlir][memref] Fix offset update in emulating narrow type for strided memref (llvm#67714)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offset when converting type in emulating narrow types did not account for the offset in strided memrefs. This patch fixes this.