[llvm-readtapi] Add symlink to call readtapi

[cyndyishida]

No description provided.

[cyndyishida]

This may be overkill but I didn't figure out a better way to install both the tool and symlink when adding readtapi to LLVM_DISTRIBUTION_COMPONENTS

[ributzka]

I see the usage of add_llvm_tool_symlink in other tools. Could that simplify the change?

[cyndyishida]

I see the usage of add_llvm_tool_symlink in other tools. Could that simplify the change?

I tried that initially. AFAICT it doesn't create a target, so I couldn't figure out how to get that symlink as a part of the installation step. I ended up doing a simpler version of https://github.com/llvm/llvm-project/blob/main/llvm-libgcc/CMakeLists.txt#L134

[ributzka]

I am looking at llvm-nm as an example, which also has the symlink. llvm-nm is also part of LLVM_TOOLCHAIN_TOOLS, but I don't see llvm-readtapi in that list.

[ributzka]

`llvm-nm' seems special, since it is considered a binutils tool.

[cyndyishida]

`llvm-nm' seems special, since it is considered a binutils tool.

Yes, there are BINUTILS and CCTOOLS and TOOLCHAIN_TOOLS. I'm not opposed to adding readtapi to TOOLCHAIN_TOOLS but I still want to be able to install readtapi as a part of downstream tapi, separate from the rest of the llvm tools.

[ributzka]

LGTM

[cyndyishida]

I see the usage of add_llvm_tool_symlink in other tools. Could that simplify the change?

For the sake of completeness, this is actually enough for my goal to install downstream. It turned out the downstream project had some defaults that didn't play nicely with llvm-tools. Specifically set(LLVM_BUILD_TOOLS OFF CACHE BOOL "")

[smeenai]

LGTM