Skip to content

[ConstantRange] Handle Intrinsic::cttz #67917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions llvm/include/llvm/IR/ConstantRange.h
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,10 @@ class [[nodiscard]] ConstantRange {
/// ignoring a possible zero value contained in the input range.
ConstantRange ctlz(bool ZeroIsPoison = false) const;

/// Calculate cttz range. If \p ZeroIsPoison is set, the range is computed
/// ignoring a possible zero value contained in the input range.
ConstantRange cttz(bool ZeroIsPoison = false) const;

/// Calculate ctpop range.
ConstantRange ctpop() const;

Expand Down
75 changes: 75 additions & 0 deletions llvm/lib/IR/ConstantRange.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -949,6 +949,7 @@ bool ConstantRange::isIntrinsicSupported(Intrinsic::ID IntrinsicID) {
case Intrinsic::smax:
case Intrinsic::abs:
case Intrinsic::ctlz:
case Intrinsic::cttz:
case Intrinsic::ctpop:
return true;
default:
Expand Down Expand Up @@ -987,6 +988,12 @@ ConstantRange ConstantRange::intrinsic(Intrinsic::ID IntrinsicID,
assert(ZeroIsPoison->getBitWidth() == 1 && "Must be boolean");
return Ops[0].ctlz(ZeroIsPoison->getBoolValue());
}
case Intrinsic::cttz: {
const APInt *ZeroIsPoison = Ops[1].getSingleElement();
assert(ZeroIsPoison && "Must be known (immarg)");
assert(ZeroIsPoison->getBitWidth() == 1 && "Must be boolean");
return Ops[0].cttz(ZeroIsPoison->getBoolValue());
}
case Intrinsic::ctpop:
return Ops[0].ctpop();
default:
Expand Down Expand Up @@ -1739,6 +1746,74 @@ ConstantRange ConstantRange::ctlz(bool ZeroIsPoison) const {
APInt(getBitWidth(), getUnsignedMin().countl_zero() + 1));
}

static ConstantRange getUnsignedCountTrailingZerosRange(const APInt &Lower,
const APInt &Upper) {
assert(!ConstantRange(Lower, Upper).isWrappedSet() &&
"Unexpected wrapped set.");
assert(Lower != Upper && "Unexpected empty set.");
unsigned BitWidth = Lower.getBitWidth();
if (Lower + 1 == Upper)
return ConstantRange(APInt(BitWidth, Lower.countr_zero()));
if (Lower.isZero())
return ConstantRange(APInt::getZero(BitWidth),
APInt(BitWidth, BitWidth + 1));

// Calculate longest common prefix.
unsigned LCPLength = (Lower ^ (Upper - 1)).countl_zero();
// If Lower is {LCP, 000...}, the maximum is Lower.countr_zero().
// Otherwise, the maximum is BitWidth - LCPLength - 1 ({LCP, 100...}).
return ConstantRange(
APInt::getZero(BitWidth),
APInt(BitWidth,
std::max(BitWidth - LCPLength - 1, Lower.countr_zero()) + 1));
}

ConstantRange ConstantRange::cttz(bool ZeroIsPoison) const {
if (isEmptySet())
return getEmpty();

unsigned BitWidth = getBitWidth();
APInt Zero = APInt::getZero(BitWidth);
if (ZeroIsPoison && contains(Zero)) {
// ZeroIsPoison is set, and zero is contained. We discern three cases, in
// which a zero can appear:
// 1) Lower is zero, handling cases of kind [0, 1), [0, 2), etc.
// 2) Upper is zero, wrapped set, handling cases of kind [3, 0], etc.
// 3) Zero contained in a wrapped set, e.g., [3, 2), [3, 1), etc.

if (Lower.isZero()) {
if (Upper == 1) {
// We have in input interval of kind [0, 1). In this case we cannot
// really help but return empty-set.
return getEmpty();
}

// Compute the resulting range by excluding zero from Lower.
return getUnsignedCountTrailingZerosRange(APInt(BitWidth, 1), Upper);
} else if (Upper == 1) {
// Compute the resulting range by excluding zero from Upper.
return getUnsignedCountTrailingZerosRange(Lower, Zero);
} else {
ConstantRange CR1 = getUnsignedCountTrailingZerosRange(Lower, Zero);
ConstantRange CR2 =
getUnsignedCountTrailingZerosRange(APInt(BitWidth, 1), Upper);
return CR1.unionWith(CR2);
}
}

if (isFullSet())
return getNonEmpty(Zero, APInt(BitWidth, BitWidth + 1));
if (!isWrappedSet())
return getUnsignedCountTrailingZerosRange(Lower, Upper);
// The range is wrapped. We decompose it into two ranges, [0, Upper) and
// [Lower, 0).
// Handle [Lower, 0)
ConstantRange CR1 = getUnsignedCountTrailingZerosRange(Lower, Zero);
// Handle [0, Upper)
ConstantRange CR2 = getUnsignedCountTrailingZerosRange(Zero, Upper);
return CR1.unionWith(CR2);
}

static ConstantRange getUnsignedPopCountRange(const APInt &Lower,
const APInt &Upper) {
assert(!ConstantRange(Lower, Upper).isWrappedSet() &&
Expand Down
3 changes: 1 addition & 2 deletions llvm/test/Transforms/CorrelatedValuePropagation/range.ll
Original file line number Diff line number Diff line change
Expand Up @@ -1016,8 +1016,7 @@ define i1 @cttz_fold(i16 %x) {
; CHECK-NEXT: br i1 [[CMP]], label [[IF:%.*]], label [[ELSE:%.*]]
; CHECK: if:
; CHECK-NEXT: [[CTTZ:%.*]] = call i16 @llvm.cttz.i16(i16 [[X]], i1 true)
; CHECK-NEXT: [[RES:%.*]] = icmp uge i16 [[CTTZ]], 8
; CHECK-NEXT: ret i1 [[RES]]
; CHECK-NEXT: ret i1 false
; CHECK: else:
; CHECK-NEXT: ret i1 false
;
Expand Down
14 changes: 14 additions & 0 deletions llvm/unittests/IR/ConstantRangeTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2438,6 +2438,20 @@ TEST_F(ConstantRangeTest, Ctlz) {
});
}

TEST_F(ConstantRangeTest, Cttz) {
TestUnaryOpExhaustive(
[](const ConstantRange &CR) { return CR.cttz(); },
[](const APInt &N) { return APInt(N.getBitWidth(), N.countr_zero()); });

TestUnaryOpExhaustive(
[](const ConstantRange &CR) { return CR.cttz(/*ZeroIsPoison=*/true); },
[](const APInt &N) -> std::optional<APInt> {
if (N.isZero())
return std::nullopt;
return APInt(N.getBitWidth(), N.countr_zero());
});
}

TEST_F(ConstantRangeTest, Ctpop) {
TestUnaryOpExhaustive(
[](const ConstantRange &CR) { return CR.ctpop(); },
Expand Down