[AST] Use explicit type erasure in TypeSourceInfo constructor #68435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
bonktree
force-pushed
the
fix-class-memaccess
branch
from
753c2e0 to
2b8af8b
Compare
cor3ntin
reviewed
Oct 10, 2023
When this file is included in a project compiled with GCC 13 -Werror,
compilation fails with the following diagnostic:
/usr/lib/llvm-17.0/include/clang/AST/TypeLoc.h: In constructor 'clang::TypeSourceInfo::TypeSourceInfo(clang::QualType, size_t)':
/usr/lib/llvm-17.0/include/clang/AST/TypeLoc.h:245:9: error: 'void* memset(void*, int, size_t)' clearing an object of non-trivial type 'class clang::TypeSourceInfo'; use assignment instead
+[-Werror=class-memaccess]
245 | memset(this + 1, 0, DataSize);
| ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
To avoid this, we add an explicit type cast. The cast to void makes
sense, since other member functions of TypeSourceInfo also treat the
buffer `(this + 1)` of length `DataSize` as opaque memory, and was
likely left out by mistake.
Fixes: 4498663 ("[AST] Initialized data after TypeSourceInfo")
bonktree
force-pushed
the
fix-class-memaccess
branch
from
2b8af8b to
021a066
Compare
|
Ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this file is included in a project compiled with GCC 13
-Werror, compilation fails with the following diagnostic:/usr/lib/llvm-17.0/include/clang/AST/TypeLoc.h: In constructor 'clang::TypeSourceInfo::TypeSourceInfo(clang::QualType, size_t)': /usr/lib/llvm-17.0/include/clang/AST/TypeLoc.h:245:9: error: 'void* memset(void*, int, size_t)' clearing an object of non-trivial type 'class clang::TypeSourceInfo'; use assignment instead [-Werror=class-memaccess] 245 | memset(this + 1, 0, DataSize); | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~To avoid this, we add an explicit type cast. The cast to
void*makes sense, since other member functions ofTypeSourceInfoalso treat the buffer(this + 1)of lengthDataSizeas opaque memory, and was likely left out by mistake.Fixes: 4498663 ("[AST] Initialized data after TypeSourceInfo")
I also suggest to apply this to release/17.x if possible.