[mlir][nfc] Rename type constraint for scalable vectors #68808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency with other predicates, rename: * allDimsScalableVectorTypePred -> IsVectorTypeWithAllDimsScalablePred
|
@llvm/pr-subscribers-mlir-sme @llvm/pr-subscribers-mlir-ods Author: Andrzej Warzyński (banach-space) ChangesFor consistency with other predicates, rename:
Full diff: https://github.com/llvm/llvm-project/pull/68808.diff 2 Files Affected:
diff --git a/mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOps.td b/mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOps.td
index e09092268082dd3..049c9759d70bf43 100644
--- a/mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOps.td
+++ b/mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOps.td
@@ -27,7 +27,7 @@ include "mlir/Interfaces/InferTypeOpInterface.td"
class SMETileType<Type datatype, list<int> dims, string description>
: ShapedContainerType<[datatype],
- And<[IsVectorOfRankPred<[2]>, allDimsScalableVectorTypePred,
+ And<[IsVectorOfRankPred<[2]>, IsVectorTypeWithAllDimsScalablePred,
IsVectorOfShape<dims>]>,
description>;
diff --git a/mlir/include/mlir/IR/CommonTypeConstraints.td b/mlir/include/mlir/IR/CommonTypeConstraints.td
index 4fc14e30b8a10d0..00dcc66a576f148 100644
--- a/mlir/include/mlir/IR/CommonTypeConstraints.td
+++ b/mlir/include/mlir/IR/CommonTypeConstraints.td
@@ -38,7 +38,7 @@ def IsScalableVectorTypePred : CPred<[{::llvm::isa<::mlir::VectorType>($_self) &
::llvm::cast<VectorType>($_self).isScalable()}]>;
// Whether a type is a VectorType and all dimensions are scalable.
-def allDimsScalableVectorTypePred : And<[
+def IsVectorTypeWithAllDimsScalablePred : And<[
IsVectorTypePred,
CPred<[{::llvm::cast<::mlir::VectorType>($_self).allDimsScalable()}]>
]>;
|
MacDue
approved these changes
Oct 11, 2023
| @@ -27,7 +27,7 @@ include "mlir/Interfaces/InferTypeOpInterface.td" | |||
|
|
|||
| class SMETileType<Type datatype, list<int> dims, string description> | |||
| : ShapedContainerType<[datatype], | |||
| And<[IsVectorOfRankPred<[2]>, allDimsScalableVectorTypePred, | |||
| And<[IsVectorOfRankPred<[2]>, IsVectorTypeWithAllDimsScalablePred, | |||
There was a problem hiding this comment.
Not required: The IsVectorOfRankPred<[2]> is redundant as the dims list always has two elements.
Suggested change
| And<[IsVectorOfRankPred<[2]>, IsVectorTypeWithAllDimsScalablePred, | |
| And<[IsVectorTypeWithAllDimsScalablePred, |
There was a problem hiding this comment.
Ha, interesting! I will keep it as a useful bit of documentation.
c-rhodes
approved these changes
Oct 11, 2023
+1 Let me update this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with other predicates, rename: