Skip to content

[LLDB][NFC] Remove dead code #68927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2023
Merged

[LLDB][NFC] Remove dead code #68927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions lldb/include/lldb/Symbol/CompilerType.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,6 @@ class CompilerType {

bool IsConst() const;

bool IsCStringType(uint32_t &length) const;

bool IsDefined() const;

bool IsFloatingPointType(uint32_t &count, bool &is_complex) const;
Expand Down Expand Up @@ -437,21 +435,11 @@ class CompilerType {
LLVM_DUMP_METHOD void dump() const;
#endif

void DumpValue(ExecutionContext *exe_ctx, Stream *s, lldb::Format format,
const DataExtractor &data, lldb::offset_t data_offset,
size_t data_byte_size, uint32_t bitfield_bit_size,
uint32_t bitfield_bit_offset, bool show_types,
bool show_summary, bool verbose, uint32_t depth);

bool DumpTypeValue(Stream *s, lldb::Format format, const DataExtractor &data,
lldb::offset_t data_offset, size_t data_byte_size,
uint32_t bitfield_bit_size, uint32_t bitfield_bit_offset,
ExecutionContextScope *exe_scope);

void DumpSummary(ExecutionContext *exe_ctx, Stream *s,
const DataExtractor &data, lldb::offset_t data_offset,
size_t data_byte_size);

/// Dump to stdout.
void DumpTypeDescription(lldb::DescriptionLevel level =
lldb::eDescriptionLevelFull) const;
Expand Down
9 changes: 0 additions & 9 deletions lldb/include/lldb/Symbol/Type.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,15 +148,6 @@ class Type : public std::enable_shared_from_this<Type>, public UserID {

ConstString GetQualifiedName();

void DumpValue(ExecutionContext *exe_ctx, Stream *s,
const DataExtractor &data, uint32_t data_offset,
bool show_type, bool show_summary, bool verbose,
lldb::Format format = lldb::eFormatDefault);

bool DumpValueInMemory(ExecutionContext *exe_ctx, Stream *s,
lldb::addr_t address, AddressType address_type,
bool show_types, bool show_summary, bool verbose);

bool ReadFromMemory(ExecutionContext *exe_ctx, lldb::addr_t address,
AddressType address_type, DataExtractor &data);

Expand Down
20 changes: 1 addition & 19 deletions lldb/include/lldb/Symbol/TypeSystem.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,14 +384,6 @@ class TypeSystem : public PluginInterface,
dump(lldb::opaque_compiler_type_t type) const = 0;
#endif

virtual void DumpValue(lldb::opaque_compiler_type_t type,
ExecutionContext *exe_ctx, Stream &s,
lldb::Format format, const DataExtractor &data,
lldb::offset_t data_offset, size_t data_byte_size,
uint32_t bitfield_bit_size,
uint32_t bitfield_bit_offset, bool show_types,
bool show_summary, bool verbose, uint32_t depth) = 0;

virtual bool DumpTypeValue(lldb::opaque_compiler_type_t type, Stream &s,
lldb::Format format, const DataExtractor &data,
lldb::offset_t data_offset, size_t data_byte_size,
Expand All @@ -418,26 +410,16 @@ class TypeSystem : public PluginInterface,
/// This should not modify the state of the TypeSystem if possible.
virtual void Dump(llvm::raw_ostream &output) = 0;

// TODO: These methods appear unused. Should they be removed?

/// This is used by swift.
virtual bool IsRuntimeGeneratedType(lldb::opaque_compiler_type_t type) = 0;

virtual void DumpSummary(lldb::opaque_compiler_type_t type,
ExecutionContext *exe_ctx, Stream &s,
const DataExtractor &data,
lldb::offset_t data_offset,
size_t data_byte_size) = 0;

// TODO: Determine if these methods should move to TypeSystemClang.

virtual bool IsPointerOrReferenceType(lldb::opaque_compiler_type_t type,
CompilerType *pointee_type) = 0;

virtual unsigned GetTypeQualifiers(lldb::opaque_compiler_type_t type) = 0;

virtual bool IsCStringType(lldb::opaque_compiler_type_t type,
uint32_t &length) = 0;

virtual std::optional<size_t>
GetTypeBitAlign(lldb::opaque_compiler_type_t type,
ExecutionContextScope *exe_scope) = 0;
Expand Down
Loading