Skip to content

[libc++] <experimental/simd> Add operator value_type() of simd reference #68960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

joy2myself
Copy link
Member

No description provided.

@joy2myself joy2myself requested a review from a team as a code owner October 13, 2023 07:25
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Oct 13, 2023
Copy link
Contributor

@philnik777 philnik777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with my comments addressed.

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

✅ With the latest revision this PR passed the C/C++ code formatter.

@joy2myself
Copy link
Member Author

@philnik777 Hi! I find the test of operator value_type() has dependencies to subscript operators of simd/simd_mask. So I add the implementation of subscript operators. You may need to review it again. Thanks!

@philnik777 philnik777 merged commit dc53410 into llvm:main Oct 23, 2023
Guzhu-AMD pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Oct 26, 2023
Local branch amd-gfx 1ab2a89 Merged main:ab261eb38a6e into amd-gfx:716677fafc9c
Remote branch main dc53410 [libc++] <experimental/simd> Add operator value_type() of simd reference (llvm#68960)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants