[flang] Do not stop on mismatched DATA substring length #69336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://reviews.llvm.org/D143819 turned mismatched DATA substring from a crash into a warning. However, the resulting DATA was incorrect when there were subsequent DATA values after the mismatch because the DATA to init conversion stopped. This change let the DATA to init continue. I added a LengthMismatch tag instead of using SizeMismatch because the other situation where SizeMismatch is returned seem like bug situations to me (the DATA value is dropped and the offset is not advanced), so I did not want to continue DATA processing in these cases.
klausler
reviewed
Oct 17, 2023
klausler
approved these changes
Oct 20, 2023
Guzhu-AMD
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Oct 26, 2023
Local branch amd-gfx 716677f Merged main:1e43975652e5 into amd-gfx:0f5dcae1ff2f Remote branch main ab261eb [flang] Do not stop on mismatched DATA substring length (llvm#69336)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://reviews.llvm.org/D143819 turned mismatched DATA substring from a crash into a warning. However, the resulting DATA was incorrect when there were subsequent DATA values after the mismatch because the DATA to init conversion stopped. This change let the DATA to init continue.
I added a LengthMismatch tag instead of using SizeMismatch because the other situation where SizeMismatch is returned seem like bug situations to me (the DATA value is dropped and the offset is not advanced), so I did not want to continue DATA processing in these cases.