Skip to content

[IPO] Remove unused function getAndUpdateAAFor #69544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kazutakahirata
Copy link
Contributor

The last use was removed by:

commit 18d9f7e
Author: Johannes Doerfert [email protected]
Date: Wed Jul 5 15:35:24 2023 -0700

The last use was removed by:

  commit 18d9f7e
  Author: Johannes Doerfert <[email protected]>
  Date:   Wed Jul 5 15:35:24 2023 -0700
@llvmbot
Copy link
Member

llvmbot commented Oct 19, 2023

@llvm/pr-subscribers-llvm-transforms

Author: Kazu Hirata (kazutakahirata)

Changes

The last use was removed by:

commit 18d9f7e
Author: Johannes Doerfert <[email protected]>
Date: Wed Jul 5 15:35:24 2023 -0700


Full diff: https://github.com/llvm/llvm-project/pull/69544.diff

1 Files Affected:

  • (modified) llvm/include/llvm/Transforms/IPO/Attributor.h (-12)
diff --git a/llvm/include/llvm/Transforms/IPO/Attributor.h b/llvm/include/llvm/Transforms/IPO/Attributor.h
index bd1bd8261123e51..7190036d60c8c64 100644
--- a/llvm/include/llvm/Transforms/IPO/Attributor.h
+++ b/llvm/include/llvm/Transforms/IPO/Attributor.h
@@ -1541,18 +1541,6 @@ struct Attributor {
                                     /* ForceUpdate */ false);
   }
 
-  /// Similar to getAAFor but the return abstract attribute will be updated (via
-  /// `AbstractAttribute::update`) even if it is found in the cache. This is
-  /// especially useful for AAIsDead as changes in liveness can make updates
-  /// possible/useful that were not happening before as the abstract attribute
-  /// was assumed dead.
-  template <typename AAType>
-  const AAType *getAndUpdateAAFor(const AbstractAttribute &QueryingAA,
-                                  const IRPosition &IRP, DepClassTy DepClass) {
-    return getOrCreateAAFor<AAType>(IRP, &QueryingAA, DepClass,
-                                    /* ForceUpdate */ true);
-  }
-
   /// The version of getAAFor that allows to omit a querying abstract
   /// attribute. Using this after Attributor started running is restricted to
   /// only the Attributor itself. Initial seeding of AAs can be done via this

@kazutakahirata kazutakahirata merged commit 0a925be into llvm:main Nov 1, 2023
@kazutakahirata kazutakahirata deleted the cleanup_dead_function_getAndUpdateAAFor branch November 1, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants