Skip to content

[MSVC] fix the build #69634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2023
Merged

[MSVC] fix the build #69634

merged 1 commit into from
Oct 20, 2023

Conversation

strega-nil
Copy link
Contributor

MSVC in C mode apparently doesn't consider const int to be sufficiently constant expression

This was broken in #66903.

@strega-nil
[MSVC] fix the build
99b4559 
MSVC in C mode apparently doesn't consider `const int` to be
sufficiently constant expression
@strega-nil strega-nil requested a review from asb October 19, 2023 19:47
@strega-nil strega-nil merged commit 51835df into llvm:main Oct 20, 2023
@spupyrev spupyrev mentioned this pull request Oct 23, 2023
Merged
@banach-space banach-space mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barcharcraz barcharcraz barcharcraz approved these changes

@asb asb Awaiting requested review from asb

Assignees
No one assigned
Labels
compiler-rt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@strega-nil @barcharcraz @llvmbot