[libc++][Android] Disable Android ABI list checking #69666
Conversation
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Ryan Prichard (rprichard) ChangesIssue: #69270 Full diff: https://github.com/llvm/llvm-project/pull/69666.diff 1 Files Affected:
diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot
index 69ad58ed079ea01..be96bb65ef94122 100755
--- a/libcxx/utils/ci/run-buildbot
+++ b/libcxx/utils/ci/run-buildbot
@@ -738,7 +738,6 @@ android-ndk-*)
-DCMAKE_SYSROOT=/opt/android/ndk/sysroot \
-DLIBCXX_TEST_PARAMS="${PARAMS}" \
-DLIBCXXABI_TEST_PARAMS="${PARAMS}"
- check-abi-list
${NINJA} -vC "${BUILD_DIR}" install-cxx install-cxxabi
# Start the emulator and make sure we can connect to the adb server running
|
|
It wasn't quite clear to me if we should have these ABI lists for Android, so I thought we might leave them out for the moment, #69272 (comment). |
|
@rprichard I kinda lost track here, but can you please make sure to cross-reference any Phabricator review from the PRs and vice-versa, and also abandon any Phabricator review that you are moving to github PRs? |
You folks want to be ABI stable or not? If you want to be ABI stable, then you should have these ABI lists. |
Sorry about that. The GitHub commits/PRs all referenced Phabricator reviews where it made sense. Two Phabricator reviews were closed when the PRs merged, and one was still open, so I abandoned it.
|
|
It's all good, no worries -- I just wanted to make sure but I appreciate that you already took care of everything! |
|
@ldionne Sorry about the lack of cross references between the old and new patches. That was partially my doing. This LGTM. Merging. |
|
@EricWF I don't mind the cross references, but please be careful when you merge, we had a discussion started above (#69666 (comment)). I suspect that Android actually does want the ABI testing. |
Issue: #69270