Skip to content

[clang][Interp] Implement builtin_expect #69713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2023
Merged

[clang][Interp] Implement builtin_expect #69713

merged 1 commit into from
Dec 8, 2023

Conversation

tbaederr
Copy link
Contributor

No description provided.

@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Oct 20, 2023
@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@tbaederr tbaederr force-pushed the builtin-expect branch 2 times, most recently from e369a59 to 4d3e513 Compare October 20, 2023 12:41
@tbaederr tbaederr changed the title [clang][Interp] Implement builintin_expect [clang][Interp] Implement builtin_expect Oct 20, 2023
@tbaederr
Copy link
Contributor Author

Ping

3 similar comments
@tbaederr
Copy link
Contributor Author

tbaederr commented Nov 3, 2023

Ping

@tbaederr
Copy link
Contributor Author

tbaederr commented Nov 9, 2023

Ping

@tbaederr
Copy link
Contributor Author

Ping

@tbaederr
Copy link
Contributor Author

Ping

cor3ntin
cor3ntin approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@cor3ntin cor3ntin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cor3ntin
cor3ntin reviewed Nov 29, 2023
View reviewed changes
clang/lib/AST/Interp/InterpBuiltin.cpp
@@ -34,6 +34,19 @@ PrimType getIntPrimType(const InterpState &S) {
llvm_unreachable("Int isn't 16 or 32 bit?");
}

PrimType getLongPrimType(const InterpState &S) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't suppose we can merge with getIntPrimType ?

@tbaederr tbaederr merged commit d5e2cbd into llvm:main Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cor3ntin cor3ntin cor3ntin approved these changes

Assignees
No one assigned
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbaederr @cor3ntin @llvmbot