Skip to content

[AMDGPU] Set size to all SOP pseudos #69756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions llvm/lib/Target/AMDGPU/SOPInstructions.td
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ class SOP_Pseudo<string opName, dag outs, dag ins, string asmOps,

let isPseudo = 1;
let isCodeGenOnly = 1;
let Size = 4;

string Mnemonic = opName;
string AsmOperands = asmOps;
Expand All @@ -36,7 +37,6 @@ class SOP1_Pseudo <string opName, dag outs, dag ins,
let SALU = 1;
let SOP1 = 1;
let SchedRW = [WriteSALU];
let Size = 4;
let UseNamedOperandTable = 1;

bits<1> has_src0 = 1;
Expand Down Expand Up @@ -455,7 +455,6 @@ class SOP2_Pseudo<string opName, dag outs, dag ins,
// let sdst = xxx in {
// for multiclasses that include both real and pseudo instructions.
// field bits<7> sdst = 0;
// let Size = 4; // Do we need size here?
}

class SOP2_Real<SOP_Pseudo ps, string real_name = ps.Mnemonic> :
Expand Down