[clangd] Fix RawStringLiteral being available to C and C++ versions prior to C++11 #69775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robozati
changed the title
|
Tests are randomly failing, let me get what is wrong. EDIT: Actually, it was my laptop that is low on VRAM so clang would fail to compile sometimes. The tests were passing normally. |
|
@sam-mccall @kadircet Hello! I mentioned this PR in discord, but no one assigned themselves to review so I am pinging you. |
robozati
force-pushed
the
main
branch
2 times, most recently
from
e8eb793 to
d753701
Compare
|
Confirmed working as it should. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RawStringLiteralcode action runs both on C and C++ versions prior to C++11, where this feature is unavailable.This patch adds a condition to check if the context is running a version equal or greater than C++11 and adds tests for failing in the wrong versions.
Fixes clangd/clangd#1795.