Skip to content

[clang-format] Add a new style for the clang-format source code #69814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

owenca
Copy link
Contributor

@owenca owenca commented Oct 21, 2023

No description provided.

@owenca
Copy link
Contributor Author

owenca commented Oct 21, 2023

I don't want to "advertise" this new style in the documentation but am willing to be overruled by the majority.

Copy link
Contributor

@HazardyKnusperkeks HazardyKnusperkeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is your goal with that style?

@owenca
Copy link
Contributor Author

owenca commented Oct 21, 2023

What is your goal with that style?

It was actually your idea. 😉

@rymiel
Copy link
Member

rymiel commented Oct 21, 2023

I don't want to "advertise" this new style in the documentation but am willing to be overruled by the majority.

But you added it to the help text?

(I'm fine with this being undocumented)

@owenca
Copy link
Contributor Author

owenca commented Oct 21, 2023

I was wondering myself. Will undo it before merging.

@HazardyKnusperkeks
Copy link
Contributor

What is your goal with that style?

It was actually your idea. 😉

I know, but I thought the thought was dropped. :)

So the intent is to use it on our .clang-format files?

@owenca
Copy link
Contributor Author

owenca commented Oct 21, 2023

Yep. Each file will contain only BasedOnStyle: clang-format.

@alexey-utkin
Copy link

Where is the documentation for the value? CLion reports clang-format option as an error by the reason. No doc, no schema rule.

@HazardyKnusperkeks
Copy link
Contributor

Where is the documentation for the value? CLion reports clang-format option as an error by the reason. No doc, no schema rule.

There:

I don't want to "advertise" this new style in the documentation but am willing to be overruled by the majority.

There is none, on purpose.

stefankoncarevic added a commit to stefankoncarevic/rocMLIR that referenced this pull request Jun 25, 2024
Reverted .clang-format files in the
external/llvm-project/clang/include/clang/Format directory to
resolve errors caused by the new style added in
llvm/llvm-project#69814. Our current version of clang-format
does not support this new style.
@mydeveloperday
Copy link
Contributor

Where is the documentation for the value? CLion reports clang-format option as an error by the reason. No doc, no schema rule.

Personally, I'm not a fan of CLion enough to care! especially following JetBrains slating of clang-format: (thanks for doing that at a massive public C++ forum without contacting us), their content even questionable as to its accuracy.

https://www.youtube.com/watch?v=NnQraMtpvws
https://blog.jetbrains.com/clion/2023/12/a-clangformat-story-and-the-third-clion-nova-update/

Maybe they can try contributing rather than complaining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants