-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[clang-format] Add a new style for the clang-format source code #69814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I don't want to "advertise" this new style in the documentation but am willing to be overruled by the majority. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is your goal with that style?
It was actually your idea. 😉 |
But you added it to the help text? (I'm fine with this being undocumented) |
I was wondering myself. Will undo it before merging. |
I know, but I thought the thought was dropped. :) So the intent is to use it on our |
Yep. Each file will contain only |
Where is the documentation for the value? CLion reports |
There:
There is none, on purpose. |
Reverted .clang-format files in the external/llvm-project/clang/include/clang/Format directory to resolve errors caused by the new style added in llvm/llvm-project#69814. Our current version of clang-format does not support this new style.
Personally, I'm not a fan of CLion enough to care! especially following JetBrains slating of clang-format: (thanks for doing that at a massive public C++ forum without contacting us), their content even questionable as to its accuracy. https://www.youtube.com/watch?v=NnQraMtpvws Maybe they can try contributing rather than complaining. |
No description provided.