Skip to content

[BOLT][RISCV] Use target features from object file #69836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

mtvec
Copy link
Contributor

@mtvec mtvec commented Oct 21, 2023

We used to hard-code target features for RISC-V. However, most features (with the exception of relax) are stored in the object file. This patch extracts those features to ensure BOLT's output doesn't use any features not present in the input file.

We used to hard-code target features for RISC-V. However, most features
(with the exception of relax) are stored in the object file. This patch
extracts those features to ensure BOLT's output doesn't use any features
not present in the input file.
Copy link
Contributor

@maksfb maksfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtvec mtvec merged commit 86bc486 into llvm:main Oct 23, 2023
@mtvec mtvec deleted the bolt-riscv-object-features branch October 23, 2023 07:20
aaupov added a commit to aaupov/llvm-project that referenced this pull request Oct 24, 2023
Fix clang build (`return Error => return std::move(Error)`)
aaupov added a commit that referenced this pull request Oct 24, 2023
Fix clang build (`return Error => return std::move(Error)`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants