Skip to content

[NFC] use StringSet::insert(iter, iter) instead for loop to insert #69851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2023
Merged

[NFC] use StringSet::insert(iter, iter) instead for loop to insert #69851

merged 1 commit into from
Oct 23, 2023

Conversation

HerrCai0907
Copy link
Contributor

No description provided.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Oct 21, 2023
erichkeane
erichkeane approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@erichkeane erichkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ends up being completely NFC, new form of insert is just the same loop.

@HerrCai0907 HerrCai0907 merged commit 65c9c92 into llvm:main Oct 23, 2023
@HerrCai0907 HerrCai0907 deleted the stringset-insert branch October 23, 2023 16:19
@spupyrev spupyrev mentioned this pull request Oct 23, 2023
Merged
Guzhu-AMD pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Oct 26, 2023
Merged main:65c9c9235075 into amd-gfx:41e1ac5101a9
4159e61 
Local branch amd-gfx 41e1ac5 Merged main:4b15c0ed0a5d into amd-gfx:d0409751aeb8
Remote branch main 65c9c92 [NFC] use `StringSet::insert(iter, iter)` instead for loop to insert (llvm#69851)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erichkeane erichkeane erichkeane approved these changes

@AaronBallman AaronBallman Awaiting requested review from AaronBallman

@ZarkoT ZarkoT Awaiting requested review from ZarkoT

Assignees
No one assigned
Labels
clang Clang issues not falling into any other category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HerrCai0907 @erichkeane @llvmbot